mirror of
https://github.com/RGBCube/serenity
synced 2025-07-10 00:57:35 +00:00
3de5dcf383
This fixes a few things I noticed whilst working on the inspector for Ladybird. 1. The computed and resolved values were being passed swapped around from the inspect_dom_node() IPC call. I.e. computed values were passed as resolved values and vice versa. This was then fixed by swapping them again in the InspectorWidget (two errors canceled out). 2. Resolved values were called "specified values" seemingly only in the inspect_dom_node() IPC calls. This was a little confusing so I've renamed them to back to "resolved values" for consistency. 3. The inspector took and stored the DOM JSON strings unnecessarily, all the models immediately parse the JSON and don't need the strings to hang around.
74 lines
2.4 KiB
C++
74 lines
2.4 KiB
C++
/*
|
|
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
|
* Copyright (c) 2021-2022, Sam Atkins <atkinssj@serenityos.org>
|
|
* Copyright (c) 2022, the SerenityOS developers.
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "ElementSizePreviewWidget.h"
|
|
#include <AK/String.h>
|
|
#include <LibGUI/Widget.h>
|
|
#include <LibWeb/CSS/Selector.h>
|
|
#include <LibWeb/Forward.h>
|
|
#include <LibWeb/Layout/BoxModelMetrics.h>
|
|
#include <LibWebView/Forward.h>
|
|
namespace Browser {
|
|
|
|
class InspectorWidget final : public GUI::Widget {
|
|
C_OBJECT(InspectorWidget)
|
|
public:
|
|
struct Selection {
|
|
i32 dom_node_id { 0 };
|
|
Optional<Web::CSS::Selector::PseudoElement> pseudo_element {};
|
|
|
|
bool operator==(Selection const& other) const
|
|
{
|
|
return dom_node_id == other.dom_node_id && pseudo_element == other.pseudo_element;
|
|
}
|
|
|
|
ErrorOr<String> to_string() const
|
|
{
|
|
if (pseudo_element.has_value())
|
|
return String::formatted("id: {}, pseudo: {}", dom_node_id, Web::CSS::pseudo_element_name(pseudo_element.value()));
|
|
return String::formatted("id: {}", dom_node_id);
|
|
}
|
|
};
|
|
|
|
virtual ~InspectorWidget() = default;
|
|
|
|
void set_web_view(NonnullRefPtr<WebView::OutOfProcessWebView> web_view) { m_web_view = web_view; }
|
|
void set_dom_json(StringView);
|
|
void clear_dom_json();
|
|
void set_dom_node_properties_json(Selection, StringView computed_values_json, StringView resolved_values_json, StringView custom_properties_json, StringView node_box_sizing_json);
|
|
|
|
void set_selection(Selection);
|
|
void select_default_node();
|
|
|
|
private:
|
|
InspectorWidget();
|
|
|
|
void set_selection(GUI::ModelIndex);
|
|
void load_style_json(StringView computed_values_json, StringView resolved_values_json, StringView custom_properties_json);
|
|
void update_node_box_model(StringView node_box_sizing_json);
|
|
void clear_style_json();
|
|
void clear_node_box_model();
|
|
|
|
RefPtr<WebView::OutOfProcessWebView> m_web_view;
|
|
|
|
RefPtr<GUI::TreeView> m_dom_tree_view;
|
|
RefPtr<GUI::TableView> m_computed_style_table_view;
|
|
RefPtr<GUI::TableView> m_resolved_style_table_view;
|
|
RefPtr<GUI::TableView> m_custom_properties_table_view;
|
|
RefPtr<ElementSizePreviewWidget> m_element_size_view;
|
|
|
|
Web::Layout::BoxModelMetrics m_node_box_sizing;
|
|
|
|
Optional<Selection> m_pending_selection;
|
|
Selection m_selection;
|
|
bool m_dom_loaded { false };
|
|
};
|
|
|
|
}
|