1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2026-01-21 17:21:01 +00:00
serenity/Meta
Aliaksandr Kalenik 8a829be25c LibWeb: Handle scenario when Window property setter is called on global
This commit fixes a regression introduced in
1528e9109c.

Turns out that the type of `this_value` in the property setter of the
Window object depends on how the variable is accessed. If the property
is accessed as a global variable, then this_value is of type `Window`.
For example:
```js
performance = null
```

However, when it is accessed as a property of the window object,
`this_value` is of type `WindowProxy`. For example:
```js
window.performance = null
```

This commit updates the window property setters generator to handle
both scenarios.

With this change https://discord.com/login works again.
2024-02-25 12:55:30 +01:00
..
Azure CI: Add debug logging to WPT run to see if we are overusing /tmp 2024-02-14 06:55:40 +01:00
CMake Meta: Allow collecting code coverage on Lagom 2024-02-24 17:13:16 -07:00
gn LibJS: Add ConservativeVector<T> 2024-02-22 16:44:54 +01:00
HeaderCheck
Lagom LibWeb: Handle scenario when Window property setter is called on global 2024-02-25 12:55:30 +01:00
Screenshots
ShellCompletions/zsh
Websites Meta: Add anchors to headings of man pages 2023-10-30 10:26:21 +00:00
analyze-qemu-coverage.sh
bochsrc Meta: Use BXSHARE instead of a hardcoded Bochs directory 2024-01-22 20:18:38 -07:00
build-image-extlinux.sh
build-image-grub.sh
build-image-limine.sh
build-image-qemu.sh
build-manpages-website.sh Meta: Add anchors to headings of man pages 2023-10-30 10:26:21 +00:00
build-native-partition.sh
build-root-filesystem.sh Base: Create user default Music and Pictures directories 2024-02-05 16:30:52 +01:00
check-ak-test-files.sh
check-debug-flags.sh
check-emoji.py
check-markdown.sh
check-newlines-at-eof.py
check-png-sizes.sh
check-style.py JSSpecCompiler: Add our first test :^) 2023-12-07 10:13:21 -07:00
check-symbols.sh
convert-markdown-links.lua
debug-kernel.sh
embed_as_string_view.py
export-argsparser-manpages.sh
extlinux.conf
find_compiler.sh
generate-embedded-resource-assembly.sh
generate-libwasm-spec-test.py
generate-libwasm-spec-test.sh
grub-ebr.cfg
grub-gpt.cfg
grub-mbr.cfg
install-ports-tree.sh
label-pull-requests.js
limine.cfg
lint-ci.sh
lint-clang-format.sh
lint-commit.sh
lint-executable-resources.sh
lint-gml-format.sh
lint-gn.sh
lint-keymaps.py
lint-ports.py
lint-prettier.sh
lint-python.sh
lint-shell-scripts.sh
new-project.sh
refresh-serenity-qtcreator.sh
run.py Meta: Enable serial_debug on riscv 2024-02-24 16:43:44 -07:00
run.sh Meta: Replace run.sh by run.py 2023-12-15 00:11:50 +01:00
serenity.sh Meta: Prevent "serenity.sh gdb" to close other tmux sessions 2024-02-24 16:21:45 -07:00
serenity_gdb.py Everywhere: Rename {Deprecated => Byte}String 2023-12-17 18:25:10 +03:30
shell_include.sh
test_pdf.py Meta: Let test_pdf.py be less dramatic about issue counts 2024-01-10 09:36:33 +01:00
toot-commits.js
tweet-commits.js