mirror of
				https://github.com/RGBCube/serenity
				synced 2025-10-31 17:42:43 +00:00 
			
		
		
		
	 aee4786d8e
			
		
	
	
		aee4786d8e
		
	
	
	
	
		
			
			This singleton simplifies many aspects that we struggled with before: 1. There's no need to make derived classes of Device expose the constructor as public anymore. The singleton is a friend of them, so he can call the constructor. This solves the issue with try_create_device helper neatly, hopefully for good. 2. Getting a reference of the NullDevice is now being done from this singleton, which means that NullDevice no longer needs to use its own singleton, and we can apply the try_create_device helper on it too :) 3. We can now defer registration completely after the Device constructor which means the Device constructor is merely assigning the major and minor numbers of the Device, and the try_create_device helper ensures it calls the after_inserting method immediately after construction. This creates a great opportunity to make registration more OOM-safe.
		
			
				
	
	
		
			41 lines
		
	
	
	
		
			1.2 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			41 lines
		
	
	
	
		
			1.2 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| /*
 | |
|  * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
 | |
|  *
 | |
|  * SPDX-License-Identifier: BSD-2-Clause
 | |
|  */
 | |
| 
 | |
| #pragma once
 | |
| 
 | |
| #include <AK/RefPtr.h>
 | |
| #include <AK/WeakPtr.h>
 | |
| #include <Kernel/Devices/BlockDevice.h>
 | |
| #include <Kernel/Storage/Partition/DiskPartitionMetadata.h>
 | |
| 
 | |
| namespace Kernel {
 | |
| 
 | |
| class DiskPartition final : public BlockDevice {
 | |
|     friend class DeviceManagement;
 | |
| 
 | |
| public:
 | |
|     static NonnullRefPtr<DiskPartition> create(BlockDevice&, unsigned, DiskPartitionMetadata);
 | |
|     virtual ~DiskPartition();
 | |
| 
 | |
|     virtual void start_request(AsyncBlockDeviceRequest&) override;
 | |
| 
 | |
|     // ^BlockDevice
 | |
|     virtual KResultOr<size_t> read(OpenFileDescription&, u64, UserOrKernelBuffer&, size_t) override;
 | |
|     virtual bool can_read(const OpenFileDescription&, size_t) const override;
 | |
|     virtual KResultOr<size_t> write(OpenFileDescription&, u64, const UserOrKernelBuffer&, size_t) override;
 | |
|     virtual bool can_write(const OpenFileDescription&, size_t) const override;
 | |
| 
 | |
|     const DiskPartitionMetadata& metadata() const;
 | |
| 
 | |
| private:
 | |
|     DiskPartition(BlockDevice&, unsigned, DiskPartitionMetadata);
 | |
|     virtual StringView class_name() const override;
 | |
| 
 | |
|     WeakPtr<BlockDevice> m_device;
 | |
|     DiskPartitionMetadata m_metadata;
 | |
| };
 | |
| 
 | |
| }
 |