mirror of
https://github.com/RGBCube/serenity
synced 2025-10-31 08:12:43 +00:00
aee4786d8e
This singleton simplifies many aspects that we struggled with before: 1. There's no need to make derived classes of Device expose the constructor as public anymore. The singleton is a friend of them, so he can call the constructor. This solves the issue with try_create_device helper neatly, hopefully for good. 2. Getting a reference of the NullDevice is now being done from this singleton, which means that NullDevice no longer needs to use its own singleton, and we can apply the try_create_device helper on it too :) 3. We can now defer registration completely after the Device constructor which means the Device constructor is merely assigning the major and minor numbers of the Device, and the try_create_device helper ensures it calls the after_inserting method immediately after construction. This creates a great opportunity to make registration more OOM-safe.
49 lines
1.3 KiB
C++
49 lines
1.3 KiB
C++
/*
|
|
* Copyright (c) 2021, Liav A. <liavalb@hotmail.co.il>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <AK/StringView.h>
|
|
#include <Kernel/Devices/DeviceManagement.h>
|
|
#include <Kernel/FileSystem/OpenFileDescription.h>
|
|
#include <Kernel/Storage/AHCIController.h>
|
|
#include <Kernel/Storage/IDEChannel.h>
|
|
#include <Kernel/Storage/SATADiskDevice.h>
|
|
|
|
namespace Kernel {
|
|
|
|
NonnullRefPtr<SATADiskDevice> SATADiskDevice::create(const AHCIController& controller, const AHCIPort& port, size_t sector_size, u64 max_addressable_block)
|
|
{
|
|
auto device_or_error = DeviceManagement::try_create_device<SATADiskDevice>(controller, port, sector_size, max_addressable_block);
|
|
// FIXME: Find a way to propagate errors
|
|
VERIFY(!device_or_error.is_error());
|
|
return device_or_error.release_value();
|
|
}
|
|
|
|
SATADiskDevice::SATADiskDevice(const AHCIController& controller, const AHCIPort& port, size_t sector_size, u64 max_addressable_block)
|
|
: StorageDevice(controller, sector_size, max_addressable_block)
|
|
, m_port(port)
|
|
{
|
|
}
|
|
|
|
SATADiskDevice::~SATADiskDevice()
|
|
{
|
|
}
|
|
|
|
StringView SATADiskDevice::class_name() const
|
|
{
|
|
return "SATADiskDevice";
|
|
}
|
|
|
|
void SATADiskDevice::start_request(AsyncBlockDeviceRequest& request)
|
|
{
|
|
m_port.strong_ref()->start_request(request);
|
|
}
|
|
|
|
String SATADiskDevice::storage_name() const
|
|
{
|
|
return String::formatted("hd{:c}", 'a' + minor());
|
|
}
|
|
|
|
}
|