1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 15:28:11 +00:00
serenity/Userland/Libraries/LibGUI
sin-ack d6dc81874d EditingEngine: Split selection from movement functions
This patch moves selection updates outside movement functions in
EditingEngine.  Previously, movement functions would automatically
update the selection based on whether the Shift key was pressed down
during movement.  However, not all EditingEngine subclasses want that;
VimEditingEngine being a good example (because all selection is handled
in visual mode).

Therefore, this patch moves all selection updating to
EditingEngine::on_key().  Subclasses wishing to provide custom movement
and selection semantics should override it (and VimEditingEngine already
does).
2021-04-27 09:03:38 +02:00
..
Wizards Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
AboutDialog.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
AboutDialog.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
AbstractButton.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
AbstractButton.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
AbstractSlider.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
AbstractSlider.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
AbstractTableView.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
AbstractTableView.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
AbstractView.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
AbstractView.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Action.cpp AK: Rename adopt() to adopt_ref() 2021-04-23 16:46:57 +02:00
Action.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
ActionGroup.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
ActionGroup.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Application.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Application.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
AutocompleteProvider.cpp AK: Rename adopt() to adopt_ref() 2021-04-23 16:46:57 +02:00
AutocompleteProvider.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
BoxLayout.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
BoxLayout.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Breadcrumbbar.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Breadcrumbbar.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Button.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Button.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Calendar.cpp Calendar: Swap Liza for Marieta 2021-04-26 18:41:54 +02:00
Calendar.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
CheckBox.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
CheckBox.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Clipboard.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Clipboard.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
CMakeLists.txt LibGUI: Make common locations configurable 2021-04-26 18:57:57 +02:00
ColorInput.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
ColorInput.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
ColorPicker.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
ColorPicker.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
ColumnsView.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
ColumnsView.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
ComboBox.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
ComboBox.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Command.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Command.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
CommonLocationsProvider.cpp LibGUI: Make common locations configurable 2021-04-26 18:57:57 +02:00
CommonLocationsProvider.h LibGUI: Make common locations configurable 2021-04-26 18:57:57 +02:00
Desktop.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Desktop.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Dialog.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Dialog.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
DisplayLink.cpp AK: Rename adopt() to adopt_ref() 2021-04-23 16:46:57 +02:00
DisplayLink.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
DragOperation.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
DragOperation.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
EditingEngine.cpp EditingEngine: Split selection from movement functions 2021-04-27 09:03:38 +02:00
EditingEngine.h EditingEngine: Split selection from movement functions 2021-04-27 09:03:38 +02:00
EmojiInputDialog.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
EmojiInputDialog.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Event.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Event.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
FileIconProvider.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
FileIconProvider.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
FilePicker.cpp LibGUI: Make common locations configurable 2021-04-26 18:57:57 +02:00
FilePicker.h LibGUI: Make common locations configurable 2021-04-26 18:57:57 +02:00
FilePickerDialog.gml Everywhere: It's now "Foobar", not "FooBar", and not "foo bar" 2021-04-13 16:58:15 +02:00
FileSystemModel.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
FileSystemModel.h AK: Rename adopt() to adopt_ref() 2021-04-23 16:46:57 +02:00
FilteringProxyModel.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
FilteringProxyModel.h AK: Rename adopt() to adopt_ref() 2021-04-23 16:46:57 +02:00
FocusSource.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
FontPicker.cpp AK: Rename adopt() to adopt_ref() 2021-04-23 16:46:57 +02:00
FontPicker.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
FontPickerDialog.gml LibGUI: Allow arbitrary font size in FontPicker 2021-04-16 23:54:03 +02:00
FontPickerWeightModel.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Forward.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Frame.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Frame.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
GMLFormatter.cpp Everywhere: Use linusg@serenityos.org for my copyright headers 2021-04-22 22:51:19 +02:00
GMLFormatter.h Everywhere: Use linusg@serenityos.org for my copyright headers 2021-04-22 22:51:19 +02:00
GMLLexer.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
GMLLexer.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
GMLParser.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
GMLParser.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
GMLSyntaxHighlighter.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
GMLSyntaxHighlighter.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
GroupBox.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
GroupBox.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
HeaderView.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
HeaderView.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Icon.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Icon.h AK: Rename adopt() to adopt_ref() 2021-04-23 16:46:57 +02:00
IconView.cpp LibGUI: Remove some unused cruft from GUI::IconView 2021-04-24 18:50:12 +02:00
IconView.h LibGUI: Remove some unused cruft from GUI::IconView 2021-04-24 18:50:12 +02:00
ImageWidget.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
ImageWidget.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
INILexer.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
INILexer.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
INISyntaxHighlighter.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
INISyntaxHighlighter.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
InputBox.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
InputBox.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
ItemListModel.h AK: Rename adopt() to adopt_ref() 2021-04-23 16:46:57 +02:00
JsonArrayModel.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
JsonArrayModel.h AK: Rename adopt() to adopt_ref() 2021-04-23 16:46:57 +02:00
Label.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Label.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Layout.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Layout.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
LazyWidget.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
LazyWidget.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
LinkLabel.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
LinkLabel.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
ListView.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
ListView.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Margins.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Menu.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Menu.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Menubar.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Menubar.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
MenuItem.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
MenuItem.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
MessageBox.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
MessageBox.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Model.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Model.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
ModelEditingDelegate.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
ModelIndex.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
ModelIndex.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
ModelRole.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
ModelSelection.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
ModelSelection.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
MultiView.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
MultiView.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Notification.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Notification.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
OpacitySlider.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
OpacitySlider.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Painter.cpp LibGUI: Prevent a Painter's clip_rect from being outside of its target 2021-04-24 15:57:20 +02:00
Painter.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
ProcessChooser.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
ProcessChooser.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Progressbar.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Progressbar.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
RadioButton.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
RadioButton.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
RegularEditingEngine.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
RegularEditingEngine.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
ResizeCorner.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
ResizeCorner.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
RunningProcessesModel.cpp AK: Rename adopt() to adopt_ref() 2021-04-23 16:46:57 +02:00
RunningProcessesModel.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
ScrollableWidget.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
ScrollableWidget.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Scrollbar.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Scrollbar.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
SeparatorWidget.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
SeparatorWidget.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Shortcut.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Shortcut.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Slider.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Slider.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
SortingProxyModel.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
SortingProxyModel.h AK: Rename adopt() to adopt_ref() 2021-04-23 16:46:57 +02:00
SpinBox.cpp LibGUI: Allow bypassing hook when setting SpinBox range 2021-04-23 11:08:11 +02:00
SpinBox.h LibGUI: Allow bypassing hook when setting SpinBox range 2021-04-23 11:08:11 +02:00
Splitter.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Splitter.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
StackWidget.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
StackWidget.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Statusbar.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Statusbar.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
TableView.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
TableView.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
TabWidget.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
TabWidget.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
TextBox.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
TextBox.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
TextDocument.cpp LibGUI: Select last word when double clicking at the end of a line 2021-04-25 19:51:03 +02:00
TextDocument.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
TextEditor.cpp EditingEngine: Split selection from movement functions 2021-04-27 09:03:38 +02:00
TextEditor.h EditingEngine: Split selection from movement functions 2021-04-27 09:03:38 +02:00
TextPosition.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
TextRange.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Toolbar.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Toolbar.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
ToolbarContainer.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
ToolbarContainer.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
TreeView.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
TreeView.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
UndoStack.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
UndoStack.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Variant.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Variant.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
VimEditingEngine.cpp EditingEngine: Split selection from movement functions 2021-04-27 09:03:38 +02:00
VimEditingEngine.h EditingEngine: Split selection from movement functions 2021-04-27 09:03:38 +02:00
Widget.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Widget.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
Window.cpp LibGUI/Window: Do not reset mouse cursor on show() 2021-04-27 08:58:13 +02:00
Window.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
WindowManagerServerConnection.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
WindowManagerServerConnection.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
WindowServerConnection.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
WindowServerConnection.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
WindowType.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00