mirror of
				https://github.com/RGBCube/serenity
				synced 2025-10-31 15:42:44 +00:00 
			
		
		
		
	 91574ed677
			
		
	
	
		91574ed677
		
	
	
	
	
		
			
			Boot profiling was previously broken due to init_stage2() passing the event mask to sys$profiling_enable() via kernel pointer, but a user pointer is expected. To fix this, I added Process::profiling_enable() as an alternative to Process::sys$profiling_enable which takes a u64 rather than a Userspace<u64 const*>. It's a bit of a hack, but it works.
		
			
				
	
	
		
			156 lines
		
	
	
	
		
			5 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			156 lines
		
	
	
	
		
			5 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| /*
 | |
|  * Copyright (c) 2018-2021, Andreas Kling <kling@serenityos.org>
 | |
|  *
 | |
|  * SPDX-License-Identifier: BSD-2-Clause
 | |
|  */
 | |
| 
 | |
| #include <Kernel/Coredump.h>
 | |
| #include <Kernel/PerformanceManager.h>
 | |
| #include <Kernel/Process.h>
 | |
| #include <Kernel/Scheduler.h>
 | |
| #include <Kernel/Time/TimeManagement.h>
 | |
| 
 | |
| namespace Kernel {
 | |
| 
 | |
| bool g_profiling_all_threads;
 | |
| PerformanceEventBuffer* g_global_perf_events;
 | |
| u64 g_profiling_event_mask;
 | |
| 
 | |
| // NOTE: event_mask needs to be passed as a pointer as u64
 | |
| //       does not fit into a register on 32bit architectures.
 | |
| ErrorOr<FlatPtr> Process::sys$profiling_enable(pid_t pid, Userspace<u64 const*> userspace_event_mask)
 | |
| {
 | |
|     VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this);
 | |
|     TRY(require_no_promises());
 | |
| 
 | |
|     auto const event_mask = TRY(copy_typed_from_user(userspace_event_mask));
 | |
|     return profiling_enable(pid, event_mask);
 | |
| }
 | |
| 
 | |
| // NOTE: This second entrypoint exists to allow the kernel to invoke the syscall to enable boot profiling.
 | |
| ErrorOr<FlatPtr> Process::profiling_enable(pid_t pid, u64 event_mask)
 | |
| {
 | |
|     VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this);
 | |
| 
 | |
|     if (pid == -1) {
 | |
|         auto credentials = this->credentials();
 | |
|         if (!credentials->is_superuser())
 | |
|             return EPERM;
 | |
|         ScopedCritical critical;
 | |
|         g_profiling_event_mask = PERF_EVENT_PROCESS_CREATE | PERF_EVENT_THREAD_CREATE | PERF_EVENT_MMAP;
 | |
|         if (g_global_perf_events) {
 | |
|             g_global_perf_events->clear();
 | |
|         } else {
 | |
|             g_global_perf_events = PerformanceEventBuffer::try_create_with_size(32 * MiB).leak_ptr();
 | |
|             if (!g_global_perf_events) {
 | |
|                 g_profiling_event_mask = 0;
 | |
|                 return ENOMEM;
 | |
|             }
 | |
|         }
 | |
| 
 | |
|         SpinlockLocker lock(g_profiling_lock);
 | |
|         if (!TimeManagement::the().enable_profile_timer())
 | |
|             return ENOTSUP;
 | |
|         g_profiling_all_threads = true;
 | |
|         PerformanceManager::add_process_created_event(*Scheduler::colonel());
 | |
|         Process::for_each([](auto& process) {
 | |
|             PerformanceManager::add_process_created_event(process);
 | |
|             return IterationDecision::Continue;
 | |
|         });
 | |
|         g_profiling_event_mask = event_mask;
 | |
|         return 0;
 | |
|     }
 | |
| 
 | |
|     auto process = Process::from_pid(pid);
 | |
|     if (!process)
 | |
|         return ESRCH;
 | |
|     if (process->is_dead())
 | |
|         return ESRCH;
 | |
|     auto credentials = this->credentials();
 | |
|     auto profile_process_credentials = process->credentials();
 | |
|     if (!credentials->is_superuser() && profile_process_credentials->uid() != credentials->euid())
 | |
|         return EPERM;
 | |
|     SpinlockLocker lock(g_profiling_lock);
 | |
|     g_profiling_event_mask = PERF_EVENT_PROCESS_CREATE | PERF_EVENT_THREAD_CREATE | PERF_EVENT_MMAP;
 | |
|     process->set_profiling(true);
 | |
|     if (!process->create_perf_events_buffer_if_needed()) {
 | |
|         process->set_profiling(false);
 | |
|         return ENOMEM;
 | |
|     }
 | |
|     g_profiling_event_mask = event_mask;
 | |
|     if (!TimeManagement::the().enable_profile_timer()) {
 | |
|         process->set_profiling(false);
 | |
|         return ENOTSUP;
 | |
|     }
 | |
|     return 0;
 | |
| }
 | |
| 
 | |
| ErrorOr<FlatPtr> Process::sys$profiling_disable(pid_t pid)
 | |
| {
 | |
|     VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this);
 | |
|     TRY(require_no_promises());
 | |
| 
 | |
|     if (pid == -1) {
 | |
|         auto credentials = this->credentials();
 | |
|         if (!credentials->is_superuser())
 | |
|             return EPERM;
 | |
|         ScopedCritical critical;
 | |
|         if (!TimeManagement::the().disable_profile_timer())
 | |
|             return ENOTSUP;
 | |
|         g_profiling_all_threads = false;
 | |
|         return 0;
 | |
|     }
 | |
| 
 | |
|     auto process = Process::from_pid(pid);
 | |
|     if (!process)
 | |
|         return ESRCH;
 | |
|     auto credentials = this->credentials();
 | |
|     auto profile_process_credentials = process->credentials();
 | |
|     if (!credentials->is_superuser() && profile_process_credentials->uid() != credentials->euid())
 | |
|         return EPERM;
 | |
|     SpinlockLocker lock(g_profiling_lock);
 | |
|     if (!process->is_profiling())
 | |
|         return EINVAL;
 | |
|     // FIXME: If we enabled the profile timer and it's not supported, how do we disable it now?
 | |
|     if (!TimeManagement::the().disable_profile_timer())
 | |
|         return ENOTSUP;
 | |
|     process->set_profiling(false);
 | |
|     return 0;
 | |
| }
 | |
| 
 | |
| ErrorOr<FlatPtr> Process::sys$profiling_free_buffer(pid_t pid)
 | |
| {
 | |
|     VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this);
 | |
|     TRY(require_no_promises());
 | |
| 
 | |
|     if (pid == -1) {
 | |
|         auto credentials = this->credentials();
 | |
|         if (!credentials->is_superuser())
 | |
|             return EPERM;
 | |
| 
 | |
|         OwnPtr<PerformanceEventBuffer> perf_events;
 | |
| 
 | |
|         {
 | |
|             ScopedCritical critical;
 | |
| 
 | |
|             perf_events = adopt_own_if_nonnull(g_global_perf_events);
 | |
|             g_global_perf_events = nullptr;
 | |
|         }
 | |
| 
 | |
|         return 0;
 | |
|     }
 | |
| 
 | |
|     auto process = Process::from_pid(pid);
 | |
|     if (!process)
 | |
|         return ESRCH;
 | |
|     auto credentials = this->credentials();
 | |
|     auto profile_process_credentials = process->credentials();
 | |
|     if (!credentials->is_superuser() && profile_process_credentials->uid() != credentials->euid())
 | |
|         return EPERM;
 | |
|     SpinlockLocker lock(g_profiling_lock);
 | |
|     if (process->is_profiling())
 | |
|         return EINVAL;
 | |
|     process->delete_perf_events_buffer();
 | |
|     return 0;
 | |
| }
 | |
| }
 |