mirror of
https://github.com/RGBCube/serenity
synced 2025-10-31 05:12:44 +00:00
c05c5a7ff4
Found due to smelly code in InodeFile::absolute_path. In particular, this replaces the following misleading methods: File::absolute_path This method *never* returns an actual path, and if called on an InodeFile (which is impossible), it would VERIFY_NOT_REACHED(). OpenFileDescription::try_serialize_absolute_path OpenFileDescription::absolute_path These methods do not guarantee to return an actual path (just like the other method), and just like Custody::absolute_path they do not guarantee accuracy. In particular, just renaming the method made a TOCTOU bug obvious. The new method signatures use KResultOr, just like try_serialize_absolute_path() already did.
67 lines
1.9 KiB
C++
67 lines
1.9 KiB
C++
/*
|
|
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <Kernel/DoubleBuffer.h>
|
|
#include <Kernel/FileSystem/File.h>
|
|
#include <Kernel/Locking/Mutex.h>
|
|
#include <Kernel/UnixTypes.h>
|
|
#include <Kernel/WaitQueue.h>
|
|
|
|
namespace Kernel {
|
|
|
|
class OpenFileDescription;
|
|
|
|
class FIFO final : public File {
|
|
public:
|
|
enum class Direction : u8 {
|
|
Neither,
|
|
Reader,
|
|
Writer
|
|
};
|
|
|
|
static KResultOr<NonnullRefPtr<FIFO>> try_create(UserID);
|
|
virtual ~FIFO() override;
|
|
|
|
UserID uid() const { return m_uid; }
|
|
|
|
KResultOr<NonnullRefPtr<OpenFileDescription>> open_direction(Direction);
|
|
KResultOr<NonnullRefPtr<OpenFileDescription>> open_direction_blocking(Direction);
|
|
|
|
#pragma GCC diagnostic push
|
|
#pragma GCC diagnostic ignored "-Woverloaded-virtual"
|
|
void attach(Direction);
|
|
void detach(Direction);
|
|
#pragma GCC diagnostic pop
|
|
|
|
private:
|
|
// ^File
|
|
virtual KResultOr<size_t> write(OpenFileDescription&, u64, const UserOrKernelBuffer&, size_t) override;
|
|
virtual KResultOr<size_t> read(OpenFileDescription&, u64, UserOrKernelBuffer&, size_t) override;
|
|
virtual KResult stat(::stat&) const override;
|
|
virtual bool can_read(const OpenFileDescription&, size_t) const override;
|
|
virtual bool can_write(const OpenFileDescription&, size_t) const override;
|
|
virtual KResultOr<NonnullOwnPtr<KString>> pseudo_path(const OpenFileDescription&) const override;
|
|
virtual StringView class_name() const override { return "FIFO"sv; }
|
|
virtual bool is_fifo() const override { return true; }
|
|
|
|
explicit FIFO(UserID, NonnullOwnPtr<DoubleBuffer> buffer);
|
|
|
|
unsigned m_writers { 0 };
|
|
unsigned m_readers { 0 };
|
|
NonnullOwnPtr<DoubleBuffer> m_buffer;
|
|
|
|
UserID m_uid { 0 };
|
|
|
|
int m_fifo_id { 0 };
|
|
|
|
WaitQueue m_read_open_queue;
|
|
WaitQueue m_write_open_queue;
|
|
Mutex m_open_lock;
|
|
};
|
|
|
|
}
|