RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 08:52:44 +00:00
Code Issues Activity Actions
serenity/Userland/Applications/PixelPaint
History
Jelle Raaijmakers f391ccfe53 LibGfx+Everywhere: Change Gfx::Rect to be endpoint exclusive 
Previously, calling `.right()` on a `Gfx::Rect` would return the last
column's coordinate still inside the rectangle, or `left + width - 1`.
This is called 'endpoint inclusive' and does not make a lot of sense for
`Gfx::Rect<float>` where a rectangle of width 5 at position (0, 0) would
return 4 as its right side. This same problem exists for `.bottom()`.

This changes `Gfx::Rect` to be endpoint exclusive, which gives us the
nice property that `width = right - left` and `height = bottom - top`.
It enables us to treat `Gfx::Rect<int>` and `Gfx::Rect<float>` exactly
the same.

All users of `Gfx::Rect` have been updated accordingly.
2023-05-23 12:35:42 +02:00
..
Filters LibGUI+Userland: Port Labels to String 2023-04-30 05:48:14 +02:00
Tools LibGfx+Everywhere: Change Gfx::Rect to be endpoint exclusive 2023-05-23 12:35:42 +02:00
CMakeLists.txt PixelPaint: Add a GradientTool 2023-01-26 10:37:26 +00:00
CreateNewImageDialog.cpp Base+Userland: Apply Human Interface Guidelines to Object text 2023-05-23 05:59:49 +02:00
CreateNewImageDialog.h PixelPaint: Add background color options to "new image" dialog 2022-12-14 15:23:07 +00:00
CreateNewLayerDialog.cpp LibGUI+Userland: Port Labels to String 2023-04-30 05:48:14 +02:00
CreateNewLayerDialog.h PixelPaint: Correctly set default layer name 2023-03-26 12:30:58 +01:00
EditGuideDialog.cpp Base+Userland: Apply Human Interface Guidelines to Object text 2023-05-23 05:59:49 +02:00
EditGuideDialog.gml Applications+Games+LibGUI: Fix layout problems 2022-06-30 11:51:25 +02:00
EditGuideDialog.h AK+Everywhere: Rename String to DeprecatedString 2022-12-06 08:54:33 +01:00
FilterGallery.cpp LibGUI+Userland: Port Labels to String 2023-04-30 05:48:14 +02:00
FilterGallery.gml PixelPaint: Tweak FilterGallery layout 2022-07-15 12:34:25 +02:00
FilterGallery.h PixelPaint: Propagate errors from making filter settings widgets 2023-02-17 22:45:44 -07:00
FilterParams.h LibGfx+Userland: Merge FrameShape and FrameShadow into FrameStyle 2023-04-30 05:49:46 +02:00
FilterPreviewWidget.cpp PixelPaint: Make filters apply to a selection if one is present 2022-11-09 22:13:26 +03:30
FilterPreviewWidget.h PixelPaint: Make filters apply to a selection if one is present 2022-11-09 22:13:26 +03:30
FilterTreeModel.cpp LibGfx: Remove try_ prefix from bitmap creation functions 2023-01-26 20:24:37 +00:00
FilterTreeModel.h AK+Everywhere: Rename String to DeprecatedString 2022-12-06 08:54:33 +01:00
Guide.h AK: Rename create<T> => make_ref_counted<T> 2021-09-03 02:36:09 +02:00
HistogramWidget.cpp PixelPaint: Remove try_ prefix from fallible Image methods 2023-01-28 22:41:36 +01:00
HistogramWidget.h PixelPaint: Extract common scope code into a generic ScopeWidget 2022-09-03 16:57:37 +01:00
IconBag.cpp Everywhere: Remove unused DeprecatedString includes 2023-04-09 22:00:54 +02:00
IconBag.h PixelPaint: Remove try_ prefix from fallible IconBag methods 2023-01-28 22:41:36 +01:00
Image.cpp LibGfx+Everywhere: Change Gfx::Rect to be endpoint exclusive 2023-05-23 12:35:42 +02:00
Image.h PixelPaint: Remove unused function definition from Image 2023-03-26 01:49:58 +01:00
ImageEditor.cpp LibGfx+Everywhere: Change Gfx::Rect to be endpoint exclusive 2023-05-23 12:35:42 +02:00
ImageEditor.h PixelPaint: Add a Duplicate Layer action 2023-03-26 00:44:26 +01:00
ImageProcessor.cpp LibCore: Remove try_ prefix from fallible SharedCircularQueue methods 2023-01-28 22:41:36 +01:00
ImageProcessor.h PixelPaint: Remove declarations for non-existent methods 2023-01-27 20:33:18 +00:00
Layer.cpp LibGfx+Everywhere: Change Gfx::Rect to be endpoint exclusive 2023-05-23 12:35:42 +02:00
Layer.h PixelPaint: Add a Duplicate Layer action 2023-03-26 00:44:26 +01:00
LayerListWidget.cpp LibGfx+Everywhere: Change Gfx::Rect to be endpoint exclusive 2023-05-23 12:35:42 +02:00
LayerListWidget.h LibGUI+Applications: Rename automatic scrolling timer functions 2022-12-26 09:27:19 +01:00
LayerPropertiesWidget.cpp LibGUI+Userland: Port Labels to String 2023-04-30 05:48:14 +02:00
LayerPropertiesWidget.h Applications: Use default constructors/destructors 2022-02-14 22:06:55 +00:00
LevelsDialog.cpp LibGUI+Userland: Port Labels to String 2023-04-30 05:48:14 +02:00
LevelsDialog.gml PixelPaint: Remove shrink_to_fit property from LevelsDialog GML 2023-02-28 08:44:05 +00:00
LevelsDialog.h PixelPaint: Add level sliders for brightness, contrast and gamma 2022-06-21 18:23:01 +01:00
main.cpp Applications: Improve FSAC error message handling 2023-05-19 06:20:41 +02:00
MainWidget.cpp Base+Userland: Apply Human Interface Guidelines to Object text 2023-05-23 05:59:49 +02:00
MainWidget.h PixelPaint: Add "Apply Mask" action 2023-02-26 13:09:16 +01:00
Mask.cpp PixelPaint: Move Mask::{get, set, to_index} to the header file 2021-10-24 17:02:44 +02:00
Mask.h LibGfx+Everywhere: Change Gfx::Rect to be endpoint exclusive 2023-05-23 12:35:42 +02:00
PaletteWidget.cpp LibGfx+Everywhere: Change Gfx::Rect to be endpoint exclusive 2023-05-23 12:35:42 +02:00
PaletteWidget.h LibCore: Move Stream-based file into the Core namespace 2023-02-13 00:50:07 +00:00
PixelPaintWindow.gml PixelPaint: Make scopes hideable 2022-10-27 12:59:20 +02:00
ProjectLoader.cpp Everywhere: Remove unused DeprecatedString includes 2023-04-09 22:00:54 +02:00
ProjectLoader.h LibCore: Move Stream-based file into the Core namespace 2023-02-13 00:50:07 +00:00
ResizeImageDialog.cpp PixelPaint: Add support for box sampling scaling 2023-05-19 18:36:36 +02:00
ResizeImageDialog.gml PixelPaint: Add support for box sampling scaling 2023-05-19 18:36:36 +02:00
ResizeImageDialog.h Meta+Userland: Pass Gfx::IntSize by value 2022-12-07 11:48:27 +01:00
ScopeWidget.cpp PixelPaint: Extract common scope code into a generic ScopeWidget 2022-09-03 16:57:37 +01:00
ScopeWidget.h PixelPaint: Extract common scope code into a generic ScopeWidget 2022-09-03 16:57:37 +01:00
Selection.cpp PixelPaint: Ensure the selection is always within image bounds 2023-05-05 16:35:42 +01:00
Selection.h Meta+Userland: Pass Gfx::IntPoint by value 2022-12-07 11:48:27 +01:00
ToolboxWidget.cpp Everywhere: Stop using NonnullOwnPtrVector 2023-03-06 23:46:35 +01:00
ToolboxWidget.h Everywhere: Remove NonnullOwnPtr.h includes 2023-03-06 23:46:35 +01:00
ToolPropertiesWidget.cpp LibGUI+Userland: Port Labels to String 2023-04-30 05:48:14 +02:00
ToolPropertiesWidget.h PixelPaint: Propagate errors from making tool property widgets 2023-02-16 23:36:58 +00:00
VectorscopeWidget.cpp PixelPaint: Remove try_ prefix from fallible Image methods 2023-01-28 22:41:36 +01:00
VectorscopeWidget.h PixelPaint: Introduce a vectorscope 2022-09-03 16:57:37 +01:00