mirror of
https://github.com/RGBCube/serenity
synced 2025-05-31 10:58:12 +00:00
e46b217e42
This patch moves us away from the accumulator-based bytecode format to one with explicit source and destination registers. The new format has multiple benefits: - ~25% faster on the Kraken and Octane benchmarks :^) - Fewer instructions to accomplish the same thing - Much easier for humans to read(!) Because this change requires a fundamental shift in how bytecode is generated, it is quite comprehensive. Main implementation mechanism: generate_bytecode() virtual function now takes an optional "preferred dst" operand, which allows callers to communicate when they have an operand that would be optimal for the result to go into. It also returns an optional "actual dst" operand, which is where the completion value (if any) of the AST node is stored after the node has "executed". One thing of note that's new: because instructions can now take locals as operands, this means we got rid of the GetLocal instruction. A side-effect of that is we have to think about the temporal deadzone (TDZ) a bit differently for locals (GetLocal would previously check for empty values and interpret that as a TDZ access and throw). We now insert special ThrowIfTDZ instructions in places where a local access may be in the TDZ, to maintain the correct behavior. There are a number of progressions and regressions from this test: A number of async generator tests have been accidentally fixed while converting the implementation to the new bytecode format. It didn't seem useful to preserve bugs in the original code when converting it. Some "does eval() return the correct completion value" tests have regressed, in particular ones related to propagating the appropriate completion after control flow statements like continue and break. These are all fairly obscure issues, and I believe we can continue working on them separately. The net test262 result is a progression though. :^) |
||
|---|---|---|
| .. | ||
| Bytecode | ||
| Contrib/Test262 | ||
| Heap | ||
| Runtime | ||
| Tests | ||
| AST.cpp | ||
| AST.h | ||
| CMakeLists.txt | ||
| Console.cpp | ||
| Console.h | ||
| CyclicModule.cpp | ||
| CyclicModule.h | ||
| Forward.h | ||
| Lexer.cpp | ||
| Lexer.h | ||
| MarkupGenerator.cpp | ||
| MarkupGenerator.h | ||
| Module.cpp | ||
| Module.h | ||
| ModuleLoading.h | ||
| Parser.cpp | ||
| Parser.h | ||
| ParserError.cpp | ||
| ParserError.h | ||
| Position.h | ||
| Print.cpp | ||
| Print.h | ||
| SafeFunction.h | ||
| Script.cpp | ||
| Script.h | ||
| SourceCode.cpp | ||
| SourceCode.h | ||
| SourceRange.h | ||
| SourceTextModule.cpp | ||
| SourceTextModule.h | ||
| SyntaxHighlighter.cpp | ||
| SyntaxHighlighter.h | ||
| SyntheticModule.cpp | ||
| SyntheticModule.h | ||
| Token.cpp | ||
| Token.h | ||