mirror of
				https://github.com/RGBCube/serenity
				synced 2025-10-30 18:12:45 +00:00 
			
		
		
		
	 d6a3be1615
			
		
	
	
		d6a3be1615
		
	
	
	
	
		
			
			Fonts with the encoding name "WinAnsiEncoding" should render missing characters above character code 040 (octal) as a "bullet" character. This patch adds Encoding::should_map_to_bullet(char_code) which is then called by char_code_to_code_point() to check if the given char code should be displayed as a bullet instead. I didn't have a good way to test this, so I've only verified that it works by manually overriding inputs to the function during the rendering stage. This takes care of a FIXME in the Annex D part of the PDF specification.
		
			
				
	
	
		
			182 lines
		
	
	
	
		
			6.2 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			182 lines
		
	
	
	
		
			6.2 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| /*
 | |
|  * Copyright (c) 2022, Matthew Olsson <mattco@serenityos.org>
 | |
|  * Copyright (c) 2022, Julian Offenhäuser <offenhaeuser@protonmail.com>
 | |
|  *
 | |
|  * SPDX-License-Identifier: BSD-2-Clause
 | |
|  */
 | |
| 
 | |
| #include <AK/Utf8View.h>
 | |
| #include <LibPDF/CommonNames.h>
 | |
| #include <LibPDF/Encoding.h>
 | |
| 
 | |
| namespace PDF {
 | |
| 
 | |
| PDFErrorOr<NonnullRefPtr<Encoding>> Encoding::create(HashMap<u16, CharDescriptor> descriptors)
 | |
| {
 | |
|     auto encoding = adopt_ref(*new Encoding());
 | |
|     encoding->m_descriptors = descriptors;
 | |
| 
 | |
|     for (auto& descriptor : descriptors)
 | |
|         encoding->m_name_mapping.set(descriptor.value.name, descriptor.value.code_point);
 | |
| 
 | |
|     return encoding;
 | |
| }
 | |
| 
 | |
| PDFErrorOr<NonnullRefPtr<Encoding>> Encoding::from_object(Document* document, NonnullRefPtr<Object> const& obj)
 | |
| {
 | |
|     if (obj->is<NameObject>()) {
 | |
|         auto name = obj->cast<NameObject>()->name();
 | |
|         if (name == "StandardEncoding")
 | |
|             return standard_encoding();
 | |
|         if (name == "MacRomanEncoding")
 | |
|             return mac_encoding();
 | |
|         if (name == "WinAnsiEncoding")
 | |
|             return windows_encoding();
 | |
| 
 | |
|         VERIFY_NOT_REACHED();
 | |
|     }
 | |
| 
 | |
|     // Make a custom encoding
 | |
|     auto dict = obj->cast<DictObject>();
 | |
| 
 | |
|     RefPtr<Encoding> base_encoding;
 | |
|     if (dict->contains(CommonNames::BaseEncoding)) {
 | |
|         auto base_encoding_obj = MUST(dict->get_object(document, CommonNames::BaseEncoding));
 | |
|         base_encoding = TRY(Encoding::from_object(document, base_encoding_obj));
 | |
|     } else {
 | |
|         base_encoding = Encoding::standard_encoding();
 | |
|     }
 | |
| 
 | |
|     auto encoding = adopt_ref(*new Encoding());
 | |
| 
 | |
|     encoding->m_descriptors = base_encoding->descriptors();
 | |
|     encoding->m_name_mapping = base_encoding->name_mapping();
 | |
| 
 | |
|     auto differences_array = TRY(dict->get_array(document, CommonNames::Differences));
 | |
| 
 | |
|     u16 current_code_point = 0;
 | |
|     bool first = true;
 | |
| 
 | |
|     for (auto& item : *differences_array) {
 | |
|         if (item.has_u32()) {
 | |
|             current_code_point = item.to_int();
 | |
|             first = false;
 | |
|         } else {
 | |
|             VERIFY(item.has<NonnullRefPtr<Object>>());
 | |
|             VERIFY(!first);
 | |
|             auto& object = item.get<NonnullRefPtr<Object>>();
 | |
|             auto name = object->cast<NameObject>()->name();
 | |
| 
 | |
|             encoding->m_descriptors.set(current_code_point, { name, base_encoding->m_name_mapping.ensure(name) });
 | |
|             current_code_point++;
 | |
|         }
 | |
|     }
 | |
| 
 | |
|     return encoding;
 | |
| }
 | |
| 
 | |
| NonnullRefPtr<Encoding> Encoding::standard_encoding()
 | |
| {
 | |
|     static NonnullRefPtr<Encoding> encoding = adopt_ref(*new Encoding());
 | |
|     if (encoding->m_descriptors.is_empty()) {
 | |
| #define ENUMERATE(string, name, standard_code, mac_code, win_code, pdf_code)   \
 | |
|     auto name##_code_point = *Utf8View(string##sv).begin();                    \
 | |
|     encoding->m_descriptors.set(standard_code, { string, name##_code_point }); \
 | |
|     encoding->m_name_mapping.set(#name, name##_code_point);
 | |
|         ENUMERATE_LATIN_CHARACTER_SET(ENUMERATE)
 | |
| #undef ENUMERATE
 | |
|     }
 | |
| 
 | |
|     return encoding;
 | |
| }
 | |
| 
 | |
| NonnullRefPtr<Encoding> Encoding::mac_encoding()
 | |
| {
 | |
|     static NonnullRefPtr<Encoding> encoding = adopt_ref(*new Encoding());
 | |
|     if (encoding->m_descriptors.is_empty()) {
 | |
| #define ENUMERATE(string, name, standard_code, mac_code, win_code, pdf_code) \
 | |
|     auto name##_code_point = *Utf8View(string##sv).begin();                  \
 | |
|     encoding->m_descriptors.set(mac_code, { string, name##_code_point });    \
 | |
|     encoding->m_name_mapping.set(#name, name##_code_point);
 | |
|         ENUMERATE_LATIN_CHARACTER_SET(ENUMERATE)
 | |
| #undef ENUMERATE
 | |
|     }
 | |
| 
 | |
|     return encoding;
 | |
| }
 | |
| 
 | |
| NonnullRefPtr<Encoding> Encoding::windows_encoding()
 | |
| {
 | |
|     static NonnullRefPtr<Encoding> encoding = adopt_ref(*new Encoding());
 | |
|     if (encoding->m_descriptors.is_empty()) {
 | |
| #define ENUMERATE(string, name, standard_code, mac_code, win_code, pdf_code) \
 | |
|     auto name##_code_point = *Utf8View(string##sv).begin();                  \
 | |
|     encoding->m_descriptors.set(win_code, { string, name##_code_point });    \
 | |
|     encoding->m_name_mapping.set(#name, name##_code_point);
 | |
|         ENUMERATE_LATIN_CHARACTER_SET(ENUMERATE)
 | |
| #undef ENUMERATE
 | |
|         encoding->m_windows = true;
 | |
|     }
 | |
| 
 | |
|     return encoding;
 | |
| }
 | |
| 
 | |
| NonnullRefPtr<Encoding> Encoding::pdf_doc_encoding()
 | |
| {
 | |
|     static NonnullRefPtr<Encoding> encoding = adopt_ref(*new Encoding());
 | |
|     if (encoding->m_descriptors.is_empty()) {
 | |
| #define ENUMERATE(string, name, standard_code, mac_code, win_code, pdf_code) \
 | |
|     auto name##_code_point = *Utf8View(string##sv).begin();                  \
 | |
|     encoding->m_descriptors.set(pdf_code, { string, name##_code_point });    \
 | |
|     encoding->m_name_mapping.set(#name, name##_code_point);
 | |
|         ENUMERATE_LATIN_CHARACTER_SET(ENUMERATE)
 | |
| #undef ENUMERATE
 | |
|     }
 | |
| 
 | |
|     return encoding;
 | |
| }
 | |
| 
 | |
| NonnullRefPtr<Encoding> Encoding::symbol_encoding()
 | |
| {
 | |
|     static NonnullRefPtr<Encoding> encoding = adopt_ref(*new Encoding());
 | |
|     if (encoding->m_descriptors.is_empty()) {
 | |
| #define ENUMERATE(string, name, code)                                 \
 | |
|     auto name##_code_point = *Utf8View(string##sv).begin();           \
 | |
|     encoding->m_descriptors.set(code, { string, name##_code_point }); \
 | |
|     encoding->m_name_mapping.set(#name, name##_code_point);
 | |
|         ENUMERATE_SYMBOL_CHARACTER_SET(ENUMERATE)
 | |
| #undef ENUMERATE
 | |
|     }
 | |
| 
 | |
|     return encoding;
 | |
| }
 | |
| 
 | |
| NonnullRefPtr<Encoding> Encoding::zapf_encoding()
 | |
| {
 | |
|     static NonnullRefPtr<Encoding> encoding = adopt_ref(*new Encoding());
 | |
|     if (encoding->m_descriptors.is_empty()) {
 | |
| #define ENUMERATE(string, name, code)                                 \
 | |
|     auto name##_code_point = *Utf8View(string##sv).begin();           \
 | |
|     encoding->m_descriptors.set(code, { string, name##_code_point }); \
 | |
|     encoding->m_name_mapping.set(#name, name##_code_point);
 | |
|         ENUMERATE_ZAPF_DINGBATS_CHARACTER_SET(ENUMERATE)
 | |
| #undef ENUMERATE
 | |
|     }
 | |
| 
 | |
|     return encoding;
 | |
| }
 | |
| 
 | |
| CharDescriptor const& Encoding::get_char_code_descriptor(u16 char_code) const
 | |
| {
 | |
|     return const_cast<Encoding*>(this)->m_descriptors.ensure(char_code);
 | |
| }
 | |
| 
 | |
| bool Encoding::should_map_to_bullet(u16 char_code) const
 | |
| {
 | |
|     // PDF Annex D table D.2, note 3:
 | |
|     // In WinAnsiEncoding, all unused codes greater than 40 (octal) map to the bullet character. However, only
 | |
|     // code 225 (octal) shall be specifically assigned to the bullet character; other codes are subject to future re-assignment.
 | |
|     return m_windows && char_code > 040 && !m_descriptors.contains(char_code);
 | |
| }
 | |
| 
 | |
| }
 |