mirror of
				https://github.com/RGBCube/serenity
				synced 2025-10-31 21:02:44 +00:00 
			
		
		
		
	 1a97382305
			
		
	
	
		1a97382305
		
	
	
	
	
		
			
			The pattern to construct `Application` was to use the `try_create` method from the `C_OBJECT` macro. While being safe from an OOM perspective, this method doesn't propagate errors from the constructor. This patch make `Application` use the `C_OBJECT_ABSTRACT` and manually define a `create` method that can bubble up errors from the construction stage. This commit also removes the ability to use `argc` and `argv` to create an `Application`, only `Main`'s `Arguments` can be used. From a user point of view, the patch renames `try_create` => `create`, hence the huge number of modified files.
		
			
				
	
	
		
			52 lines
		
	
	
	
		
			2.2 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			52 lines
		
	
	
	
		
			2.2 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| /*
 | |
|  * Copyright (c) 2019-2020, Jesse Buhagiar <jooster669@gmail.com>
 | |
|  * Copyright (c) 2021, Andreas Kling <kling@serenityos.org>
 | |
|  * Copyright (c) 2021-2022, Sam Atkins <atkinssj@serenityos.org>
 | |
|  *
 | |
|  * SPDX-License-Identifier: BSD-2-Clause
 | |
|  */
 | |
| 
 | |
| #include "BackgroundSettingsWidget.h"
 | |
| #include "DesktopSettingsWidget.h"
 | |
| #include "EffectsSettingsWidget.h"
 | |
| #include "FontSettingsWidget.h"
 | |
| #include "MonitorSettingsWidget.h"
 | |
| #include "ThemesSettingsWidget.h"
 | |
| #include <LibConfig/Client.h>
 | |
| #include <LibCore/ArgsParser.h>
 | |
| #include <LibCore/System.h>
 | |
| #include <LibGUI/Application.h>
 | |
| #include <LibGUI/Icon.h>
 | |
| #include <LibGUI/SettingsWindow.h>
 | |
| #include <LibMain/Main.h>
 | |
| 
 | |
| ErrorOr<int> serenity_main(Main::Arguments arguments)
 | |
| {
 | |
|     TRY(Core::System::pledge("stdio thread recvfd sendfd rpath cpath wpath unix proc exec"));
 | |
| 
 | |
|     auto app = TRY(GUI::Application::create(arguments));
 | |
|     Config::pledge_domain("WindowManager");
 | |
| 
 | |
|     StringView selected_tab;
 | |
|     Core::ArgsParser args_parser;
 | |
|     args_parser.add_option(selected_tab, "Tab, one of 'background', 'fonts', 'monitor', 'themes', or 'workspaces'", "open-tab", 't', "tab");
 | |
|     args_parser.parse(arguments);
 | |
| 
 | |
|     auto app_icon = GUI::Icon::default_icon("app-display-settings"sv);
 | |
| 
 | |
|     bool background_settings_changed = false;
 | |
| 
 | |
|     auto window = TRY(GUI::SettingsWindow::create("Display Settings"));
 | |
|     (void)TRY(window->add_tab<DisplaySettings::BackgroundSettingsWidget>(TRY("Background"_string), "background"sv, background_settings_changed));
 | |
|     (void)TRY(window->add_tab<DisplaySettings::ThemesSettingsWidget>("Themes"_short_string, "themes"sv, background_settings_changed));
 | |
|     (void)TRY(window->add_tab<DisplaySettings::FontSettingsWidget>("Fonts"_short_string, "fonts"sv));
 | |
|     (void)TRY(window->add_tab<DisplaySettings::MonitorSettingsWidget>("Monitor"_short_string, "monitor"sv));
 | |
|     (void)TRY(window->add_tab<DisplaySettings::DesktopSettingsWidget>(TRY("Workspaces"_string), "workspaces"sv));
 | |
|     (void)TRY(window->add_tab<GUI::DisplaySettings::EffectsSettingsWidget>("Effects"_short_string, "effects"sv));
 | |
|     window->set_active_tab(selected_tab);
 | |
| 
 | |
|     window->set_icon(app_icon.bitmap_for_size(16));
 | |
| 
 | |
|     window->show();
 | |
|     return app->exec();
 | |
| }
 |