mirror of
https://github.com/RGBCube/serenity
synced 2025-05-31 18:18:12 +00:00
e7de5cb4d2
This patch makes a few changes to the way we calculate line-height: - `line-height: normal` is now resolved using metrics from the used font (specifically, round(A + D + lineGap)). - `line-height: calc(...)` is now resolved at style compute time. - `line-height` values are now absolutized at style compute time. As a consequence of the above, we no longer need to walk the DOM ancestor chain looking for line-heights during style computation. Instead, values are inherited, resolved and absolutized locally. This is not only much faster, but also makes our line-height metrics match those of other engines like Gecko and Blink.
21 lines
1.1 KiB
Text
21 lines
1.1 KiB
Text
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
|
|
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
|
|
BlockContainer <body> at (8,20) content-size 784x22 children: not-inline
|
|
BlockContainer <p> at (8,20) content-size 784x22 children: inline
|
|
line 0 width: 151.34375, height: 22, bottom: 22, baseline: 17
|
|
frag 0 from TextNode start: 0, length: 13, rect: [13,20 141.34375x22]
|
|
"Should be red"
|
|
TextNode <#text>
|
|
InlineNode <a>
|
|
TextNode <#text>
|
|
TextNode <#text>
|
|
BlockContainer <(anonymous)> at (8,62) content-size 784x0 children: inline
|
|
TextNode <#text>
|
|
|
|
ViewportPaintable (Viewport<#document>) [0,0 800x600]
|
|
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
|
|
PaintableWithLines (BlockContainer<BODY>) [8,20 784x22] overflow: [8,20 784x42]
|
|
PaintableWithLines (BlockContainer<P>) [8,20 784x22]
|
|
InlinePaintable (InlineNode<A>)
|
|
TextPaintable (TextNode<#text>)
|
|
PaintableWithLines (BlockContainer(anonymous)) [8,62 784x0]
|