mirror of
https://github.com/RGBCube/serenity
synced 2025-05-31 18:28:12 +00:00
efae6e2270
This happens to be a sad truth for the VirtIOGPU driver - it lacked any error propagation measures and generally relied on clunky assumptions that most operations with the GPU device are infallible, although in reality much of them could fail, so we do need to handle errors. To fix this, synchronous GPU commands no longer rely on the wait queue mechanism anymore, so instead we introduce a timeout-based mechanism, similar to how other Kernel drivers use a polling based mechanism with the assumption that hardware could get stuck in an error state and we could abort gracefully. Then, we change most of the VirtIOGraphicsAdapter methods to propagate errors properly to the original callers, to ensure that if a synchronous GPU command failed, either the Kernel or userspace could do something meaningful about this situation.
92 lines
3.4 KiB
C++
92 lines
3.4 KiB
C++
/*
|
|
* Copyright (c) 2021, Sahan Fernando <sahan.h.fernando@gmail.com>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <AK/BinaryBufferWriter.h>
|
|
#include <AK/DistinctNumeric.h>
|
|
#include <Kernel/Devices/CharacterDevice.h>
|
|
#include <Kernel/Graphics/Console/Console.h>
|
|
#include <Kernel/Graphics/DisplayConnector.h>
|
|
#include <Kernel/Graphics/VirtIOGPU/GraphicsAdapter.h>
|
|
#include <Kernel/Graphics/VirtIOGPU/Protocol.h>
|
|
#include <Kernel/Memory/Region.h>
|
|
#include <LibEDID/EDID.h>
|
|
|
|
namespace Kernel::Graphics::VirtIOGPU {
|
|
|
|
class Console;
|
|
|
|
}
|
|
|
|
namespace Kernel {
|
|
|
|
class VirtIOGraphicsAdapter;
|
|
class VirtIODisplayConnector final : public DisplayConnector {
|
|
friend class Graphics::VirtIOGPU::Console;
|
|
friend class DeviceManagement;
|
|
|
|
public:
|
|
static NonnullLockRefPtr<VirtIODisplayConnector> must_create(VirtIOGraphicsAdapter& graphics_adapter, Graphics::VirtIOGPU::ScanoutID scanout_id);
|
|
|
|
void set_edid_bytes(Badge<VirtIOGraphicsAdapter>, Array<u8, 128> const& edid_bytes);
|
|
void set_safe_mode_setting_after_initialization(Badge<VirtIOGraphicsAdapter>);
|
|
Graphics::VirtIOGPU::ScanoutID scanout_id() const { return m_scanout_id; }
|
|
Graphics::VirtIOGPU::Protocol::DisplayInfoResponse::Display display_information(Badge<VirtIOGraphicsAdapter>) const;
|
|
|
|
void draw_ntsc_test_pattern(Badge<VirtIOGraphicsAdapter>);
|
|
|
|
private:
|
|
void initialize_console();
|
|
virtual bool mutable_mode_setting_capable() const override { return true; }
|
|
virtual bool double_framebuffering_capable() const override { return false; }
|
|
virtual bool partial_flush_support() const override { return true; }
|
|
virtual ErrorOr<void> set_mode_setting(ModeSetting const&) override;
|
|
virtual ErrorOr<void> set_safe_mode_setting() override;
|
|
virtual ErrorOr<void> set_y_offset(size_t y) override;
|
|
virtual ErrorOr<void> unblank() override;
|
|
|
|
// Note: VirtIO hardware requires a constant refresh to keep the screen in sync to the user.
|
|
virtual bool flush_support() const override { return true; }
|
|
// Note: Paravirtualized hardware doesn't require a defined refresh rate for modesetting.
|
|
virtual bool refresh_rate_support() const override { return false; }
|
|
|
|
virtual ErrorOr<void> flush_first_surface() override;
|
|
virtual ErrorOr<void> flush_rectangle(size_t buffer_index, FBRect const& rect) override;
|
|
|
|
virtual void enable_console() override;
|
|
virtual void disable_console() override;
|
|
|
|
static bool is_valid_buffer_index(size_t buffer_index)
|
|
{
|
|
return buffer_index == 0 || buffer_index == 1;
|
|
}
|
|
|
|
private:
|
|
VirtIODisplayConnector(VirtIOGraphicsAdapter& graphics_adapter, Graphics::VirtIOGPU::ScanoutID scanout_id);
|
|
|
|
ErrorOr<void> flush_displayed_image(Graphics::VirtIOGPU::Protocol::Rect const& dirty_rect, bool main_buffer);
|
|
void set_dirty_displayed_rect(Graphics::VirtIOGPU::Protocol::Rect const& dirty_rect, bool main_buffer);
|
|
|
|
void query_display_information();
|
|
ErrorOr<void> query_edid_from_virtio_adapter();
|
|
void query_display_edid();
|
|
|
|
void clear_to_black();
|
|
|
|
// Member data
|
|
// Context used for kernel operations (e.g. flushing resources to scanout)
|
|
Graphics::VirtIOGPU::ContextID m_kernel_context_id;
|
|
|
|
NonnullLockRefPtr<VirtIOGraphicsAdapter> m_graphics_adapter;
|
|
LockRefPtr<Graphics::Console> m_console;
|
|
Graphics::VirtIOGPU::Protocol::DisplayInfoResponse::Display m_display_info {};
|
|
Graphics::VirtIOGPU::ScanoutID m_scanout_id;
|
|
|
|
constexpr static size_t NUM_TRANSFER_REGION_PAGES = 256;
|
|
};
|
|
|
|
}
|