mirror of
				https://github.com/RGBCube/serenity
				synced 2025-10-31 04:22:45 +00:00 
			
		
		
		
	 75e42648e1
			
		
	
	
		75e42648e1
		
	
	
	
	
		
			
			This patch adds a context menu to variables in the debugger variable tree view that has an option to set the value of a variable. An input box will pop up asking for the new value of the variable, which is then parsed and used to set the actual variable.
		
			
				
	
	
		
			106 lines
		
	
	
	
		
			4.4 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			106 lines
		
	
	
	
		
			4.4 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| /*
 | |
|  * Copyright (c) 2020, Itamar S. <itamar8910@gmail.com>
 | |
|  * All rights reserved.
 | |
|  *
 | |
|  * Redistribution and use in source and binary forms, with or without
 | |
|  * modification, are permitted provided that the following conditions are met:
 | |
|  *
 | |
|  * 1. Redistributions of source code must retain the above copyright notice, this
 | |
|  *    list of conditions and the following disclaimer.
 | |
|  *
 | |
|  * 2. Redistributions in binary form must reproduce the above copyright notice,
 | |
|  *    this list of conditions and the following disclaimer in the documentation
 | |
|  *    and/or other materials provided with the distribution.
 | |
|  *
 | |
|  * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
 | |
|  * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
 | |
|  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
 | |
|  * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
 | |
|  * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
 | |
|  * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
 | |
|  * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
 | |
|  * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
 | |
|  * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 | |
|  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 | |
|  */
 | |
| 
 | |
| #include "DebugInfoWidget.h"
 | |
| #include "BacktraceModel.h"
 | |
| #include "Debugger.h"
 | |
| #include "VariablesModel.h"
 | |
| #include <AK/StringBuilder.h>
 | |
| #include <LibGUI/Action.h>
 | |
| #include <LibGUI/BoxLayout.h>
 | |
| #include <LibGUI/InputBox.h>
 | |
| #include <LibGUI/ListView.h>
 | |
| #include <LibGUI/Menu.h>
 | |
| #include <LibGUI/Model.h>
 | |
| #include <LibGUI/Splitter.h>
 | |
| #include <LibGUI/TreeView.h>
 | |
| 
 | |
| DebugInfoWidget::DebugInfoWidget()
 | |
| {
 | |
|     set_layout<GUI::HorizontalBoxLayout>();
 | |
|     auto& splitter = add<GUI::HorizontalSplitter>();
 | |
|     m_backtrace_view = splitter.add<GUI::ListView>();
 | |
|     m_variables_view = splitter.add<GUI::TreeView>();
 | |
| 
 | |
|     m_backtrace_view->on_selection = [this](auto& index) {
 | |
|         auto& model = static_cast<BacktraceModel&>(*m_backtrace_view->model());
 | |
| 
 | |
|         // Note: The reconstruction of the register set here is obviously incomplete.
 | |
|         // We currently only reconstruct eip & ebp. Ideally would also reconstruct the other registers somehow.
 | |
|         // (Other registers may be needed to get the values of variables who are not stored on the stack)
 | |
|         PtraceRegisters frame_regs {};
 | |
|         frame_regs.eip = model.frames()[index.row()].instruction_address;
 | |
|         frame_regs.ebp = model.frames()[index.row()].frame_base;
 | |
| 
 | |
|         m_variables_view->set_model(VariablesModel::create(frame_regs));
 | |
|     };
 | |
| 
 | |
|     auto edit_variable_action = GUI::Action::create("Change value", [&](auto&) {
 | |
|         m_variables_view->on_activation(m_variables_view->selection().first());
 | |
|     });
 | |
| 
 | |
|     m_variable_context_menu = GUI::Menu::construct();
 | |
|     m_variable_context_menu->add_action(edit_variable_action);
 | |
| 
 | |
|     auto is_valid_index = [](auto& index) {
 | |
|         if (!index.is_valid())
 | |
|             return false;
 | |
|         auto* variable = static_cast<const DebugInfo::VariableInfo*>(index.internal_data());
 | |
|         if (variable->location_type != DebugInfo::VariableInfo::LocationType::Address)
 | |
|             return false;
 | |
|         return variable->type.is_one_of("int", "bool");
 | |
|     };
 | |
| 
 | |
|     m_variables_view->on_context_menu_request = [this, is_valid_index](auto& index, auto& event) {
 | |
|         if (!is_valid_index(index))
 | |
|             return;
 | |
|         m_variable_context_menu->popup(event.screen_position());
 | |
|     };
 | |
| 
 | |
|     m_variables_view->on_activation = [this, is_valid_index](auto& index) {
 | |
|         if (!is_valid_index(index))
 | |
|             return;
 | |
| 
 | |
|         auto input = GUI::InputBox::construct("Enter new value:", "Set variable value", window());
 | |
| 
 | |
|         if (input->exec() == GUI::InputBox::ExecOK) {
 | |
|             auto& model = static_cast<VariablesModel&>(*m_variables_view->model());
 | |
|             model.set_variable_value(index, input->text_value(), window());
 | |
|         }
 | |
|     };
 | |
| }
 | |
| 
 | |
| void DebugInfoWidget::update_state(const DebugSession& debug_session, const PtraceRegisters& regs)
 | |
| {
 | |
|     m_variables_view->set_model(VariablesModel::create(regs));
 | |
|     m_backtrace_view->set_model(BacktraceModel::create(debug_session, regs));
 | |
|     m_backtrace_view->selection().set(m_backtrace_view->model()->index(0));
 | |
| }
 | |
| 
 | |
| void DebugInfoWidget::program_stopped()
 | |
| {
 | |
|     m_variables_view->set_model({});
 | |
| }
 |