1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 02:27:35 +00:00
serenity/Userland/Applications/HexEditor
Jelle Raaijmakers f391ccfe53 LibGfx+Everywhere: Change Gfx::Rect to be endpoint exclusive
Previously, calling `.right()` on a `Gfx::Rect` would return the last
column's coordinate still inside the rectangle, or `left + width - 1`.
This is called 'endpoint inclusive' and does not make a lot of sense for
`Gfx::Rect<float>` where a rectangle of width 5 at position (0, 0) would
return 4 as its right side. This same problem exists for `.bottom()`.

This changes `Gfx::Rect` to be endpoint exclusive, which gives us the
nice property that `width = right - left` and `height = bottom - top`.
It enables us to treat `Gfx::Rect<int>` and `Gfx::Rect<float>` exactly
the same.

All users of `Gfx::Rect` have been updated accordingly.
2023-05-23 12:35:42 +02:00
..
CMakeLists.txt HexEditor: Add selection strings to the value inspector 2023-02-15 12:13:31 +00:00
FindDialog.cpp Userland: Set Button text using the new String class 2023-02-13 00:45:09 +00:00
FindDialog.gml Base+Userland: Apply Human Interface Guidelines to Object text 2023-05-23 05:59:49 +02:00
FindDialog.h AK+Everywhere: Rename String to DeprecatedString 2022-12-06 08:54:33 +01:00
GoToOffsetDialog.cpp LibGUI+Userland: Rename try_load_from_gml() -> load_from_gml() :^) 2023-01-07 14:39:30 +01:00
GoToOffsetDialog.gml LibGUI+Apps: Convert Statusbar Labels to Segments 2022-02-24 19:09:41 +01:00
GoToOffsetDialog.h AK+Everywhere: Rename String to DeprecatedString 2022-12-06 08:54:33 +01:00
HexDocument.cpp Everywhere: Remove unintentional partial stream reads and writes 2023-03-13 15:16:20 +00:00
HexDocument.h LibCore: Move Stream-based file into the Core namespace 2023-02-13 00:50:07 +00:00
HexEditor.cpp LibGfx+Everywhere: Change Gfx::Rect to be endpoint exclusive 2023-05-23 12:35:42 +02:00
HexEditor.h Everywhere: Remove NonnullOwnPtr.h includes 2023-03-06 23:46:35 +01:00
HexEditorWidget.cpp Base+Userland: Apply Human Interface Guidelines to Object text 2023-05-23 05:59:49 +02:00
HexEditorWidget.h HexEditor: Propagate errors from HexEditorWidget::initialize_menubar() 2023-04-20 17:02:23 +01:00
HexEditorWindow.gml Applications+DevTools: Remove fixed sizes from Splitters 2022-08-30 16:28:44 +01:00
main.cpp Applications: Improve FSAC error message handling 2023-05-19 06:20:41 +02:00
SearchResultsModel.h Userland: Port Model::column_name() to String 2023-05-15 06:42:10 +02:00
ValueInspectorModel.h Userland: Port Model::column_name() to String 2023-05-15 06:42:10 +02:00