mirror of
https://github.com/RGBCube/serenity
synced 2025-05-19 23:25:08 +00:00
41a3c19cfe
This change fixes GC-leak caused by following mutual dependency: - SVGDecodedImageData owns JS::Handle for Page. - SVGDecodedImageData is owned by visited objects. by making everything inherited from HTML::DecodedImageData and ListOfAvailableImages to be GC-allocated. Generally, if visited object has a handle, very likely we leak everything visited from object in a handle.
80 lines
2.1 KiB
C++
80 lines
2.1 KiB
C++
/*
|
|
* Copyright (c) 2023, Andreas Kling <kling@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <AK/HashMap.h>
|
|
#include <AK/URL.h>
|
|
#include <LibJS/Heap/Cell.h>
|
|
#include <LibWeb/Forward.h>
|
|
#include <LibWeb/HTML/CORSSettingAttribute.h>
|
|
#include <LibWeb/HTML/Origin.h>
|
|
|
|
namespace Web::HTML {
|
|
|
|
// https://html.spec.whatwg.org/multipage/images.html#list-of-available-images
|
|
class ListOfAvailableImages : public JS::Cell {
|
|
JS_CELL(ListOfAvailableImages, Cell);
|
|
JS_DECLARE_ALLOCATOR(ListOfAvailableImages);
|
|
|
|
public:
|
|
struct Key {
|
|
AK::URL url;
|
|
HTML::CORSSettingAttribute mode;
|
|
Optional<HTML::Origin> origin;
|
|
|
|
[[nodiscard]] bool operator==(Key const& other) const;
|
|
[[nodiscard]] u32 hash() const;
|
|
|
|
private:
|
|
mutable Optional<u32> cached_hash;
|
|
};
|
|
|
|
struct Entry final : public JS::Cell {
|
|
JS_CELL(Entry, Cell);
|
|
JS_DECLARE_ALLOCATOR(Entry);
|
|
|
|
public:
|
|
static JS::NonnullGCPtr<Entry> create(JS::VM&, JS::NonnullGCPtr<DecodedImageData>, bool ignore_higher_layer_caching);
|
|
~Entry();
|
|
|
|
bool ignore_higher_layer_caching { false };
|
|
JS::NonnullGCPtr<DecodedImageData> image_data;
|
|
|
|
private:
|
|
Entry(JS::NonnullGCPtr<DecodedImageData>, bool ignore_higher_layer_caching);
|
|
};
|
|
|
|
ListOfAvailableImages();
|
|
~ListOfAvailableImages();
|
|
|
|
ErrorOr<void> add(Key const&, JS::NonnullGCPtr<DecodedImageData>, bool ignore_higher_layer_caching);
|
|
void remove(Key const&);
|
|
[[nodiscard]] JS::GCPtr<Entry> get(Key const&) const;
|
|
|
|
void visit_edges(JS::Cell::Visitor& visitor) override;
|
|
|
|
private:
|
|
HashMap<Key, JS::NonnullGCPtr<Entry>> m_images;
|
|
};
|
|
|
|
}
|
|
|
|
namespace AK {
|
|
|
|
template<>
|
|
struct Traits<Web::HTML::ListOfAvailableImages::Key> : public DefaultTraits<Web::HTML::ListOfAvailableImages::Key> {
|
|
static unsigned hash(Web::HTML::ListOfAvailableImages::Key const& key)
|
|
{
|
|
return key.hash();
|
|
}
|
|
static bool equals(Web::HTML::ListOfAvailableImages::Key const& a, Web::HTML::ListOfAvailableImages::Key const& b)
|
|
{
|
|
return a == b;
|
|
}
|
|
};
|
|
|
|
}
|