mirror of
https://github.com/RGBCube/serenity
synced 2025-07-14 13:37:35 +00:00
5611285312
Before this commit it only allocated the global object so when it wanted to lookup 'thisSheet' it could not find it in the global environment. We now hotswap the global object everytime a cell evaluated. This also fixes that SheetGlobalObject did not have an internal_has_property meaning 'A0' could not be referenced unless it was via a member lookup (this.A0). This was already broken before the bindings refactoring. The correct behavior of realms in spreadsheet is not completely clear since what is shared between sheets is not very well defined. The reason that just setting the SheetGlobalObject as the global_this_value is not enough is because ECMAScript does not check the global_this_value for members when resolving a reference in the global environment.
64 lines
1.8 KiB
C++
64 lines
1.8 KiB
C++
/*
|
|
* Copyright (c) 2020, the SerenityOS developers.
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "Forward.h"
|
|
#include <LibJS/Forward.h>
|
|
#include <LibJS/Runtime/Completion.h>
|
|
#include <LibJS/Runtime/GlobalObject.h>
|
|
|
|
namespace Spreadsheet {
|
|
|
|
struct FunctionAndArgumentIndex {
|
|
String function_name;
|
|
size_t argument_index { 0 };
|
|
};
|
|
Optional<FunctionAndArgumentIndex> get_function_and_argument_index(StringView source);
|
|
|
|
class SheetGlobalObject final : public JS::GlobalObject {
|
|
JS_OBJECT(SheetGlobalObject, JS::GlobalObject);
|
|
|
|
public:
|
|
SheetGlobalObject(Sheet&);
|
|
|
|
virtual ~SheetGlobalObject() override;
|
|
|
|
virtual JS::ThrowCompletionOr<bool> internal_has_property(JS::PropertyName const& name) const override;
|
|
virtual JS::ThrowCompletionOr<JS::Value> internal_get(JS::PropertyName const&, JS::Value receiver) const override;
|
|
virtual JS::ThrowCompletionOr<bool> internal_set(JS::PropertyName const&, JS::Value value, JS::Value receiver) override;
|
|
virtual void initialize_global_object() override;
|
|
|
|
JS_DECLARE_NATIVE_FUNCTION(get_real_cell_contents);
|
|
JS_DECLARE_NATIVE_FUNCTION(set_real_cell_contents);
|
|
JS_DECLARE_NATIVE_FUNCTION(parse_cell_name);
|
|
JS_DECLARE_NATIVE_FUNCTION(current_cell_position);
|
|
JS_DECLARE_NATIVE_FUNCTION(column_index);
|
|
JS_DECLARE_NATIVE_FUNCTION(column_arithmetic);
|
|
|
|
private:
|
|
virtual void visit_edges(Visitor&) override;
|
|
Sheet& m_sheet;
|
|
};
|
|
|
|
class WorkbookObject final : public JS::Object {
|
|
JS_OBJECT(WorkbookObject, JS::Object);
|
|
|
|
public:
|
|
WorkbookObject(Workbook&);
|
|
|
|
virtual ~WorkbookObject() override;
|
|
|
|
virtual void initialize(JS::GlobalObject&) override;
|
|
|
|
JS_DECLARE_NATIVE_FUNCTION(sheet);
|
|
|
|
private:
|
|
virtual void visit_edges(Visitor&) override;
|
|
Workbook& m_workbook;
|
|
};
|
|
|
|
}
|