RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 13:38:11 +00:00
Code Issues Activity Actions
serenity/Userland/Libraries/LibWeb/Layout
History
Andreas Kling fa43a4118e LibWeb: Handle height:auto separately for BFC root vs other block boxes 
I was wrong in 56df05ae44, there are
situations where floating children should not affect the auto height of
their parent.

It turns out we were using the "height:auto for BFC roots" algorithm for
all height:auto blocks. This patch fixes that by splitting it into two
separate functions, and implementing most of the two different variants.

Note that we don't support vertical margin collapsing here yet.

Thanks to Tim for noticing the error! :^)
2022-03-01 23:26:35 +01:00
..
BlockContainer.cpp LibWeb: Start making our layout system "transactional" 2022-02-21 18:35:12 +01:00
BlockContainer.h LibWeb: Start making our layout system "transactional" 2022-02-21 18:35:12 +01:00
BlockFormattingContext.cpp LibWeb: Always include floats when computing height:auto for blocks 2022-03-01 19:01:19 +01:00
BlockFormattingContext.h LibWeb: Create list-item markers during layout tree construction 2022-02-21 18:35:12 +01:00
Box.cpp LibWeb: Store box's containing line box fragment in FormattingState 2022-02-28 14:17:44 +01:00
Box.h LibWeb: Store box's containing line box fragment in FormattingState 2022-02-28 14:17:44 +01:00
BoxModelMetrics.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
BoxModelMetrics.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
BreakNode.cpp LibWeb: Remove old Layout::Node::split_into_lines() API 2022-01-23 01:22:41 +01:00
BreakNode.h LibWeb: Remove old Layout::Node::split_into_lines() API 2022-01-23 01:22:41 +01:00
ButtonBox.cpp LibWeb: Allow <input type="button/submit/reset"> to be styled 2022-02-28 15:46:06 +00:00
ButtonBox.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
CanvasBox.cpp LibWeb: Make intrinsic width/height/ratio a Box concept and simplify it 2021-10-14 18:39:27 +02:00
CanvasBox.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
CheckBox.cpp LibWeb: Make <input type=checkbox> fire click events when clicked :^) 2022-02-17 16:33:55 +01:00
CheckBox.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
FlexFormattingContext.cpp LibWeb: Rename FormattingState::ensure() -> get_mutable() 2022-02-21 18:35:12 +01:00
FlexFormattingContext.h LibWeb: Start making our layout system "transactional" 2022-02-21 18:35:12 +01:00
FormattingContext.cpp LibWeb: Handle height:auto separately for BFC root vs other block boxes 2022-03-01 23:26:35 +01:00
FormattingContext.h LibWeb: Handle height:auto separately for BFC root vs other block boxes 2022-03-01 23:26:35 +01:00
FormattingState.cpp LibWeb: Store box's containing line box fragment in FormattingState 2022-02-28 14:17:44 +01:00
FormattingState.h LibWeb: Store box's containing line box fragment in FormattingState 2022-02-28 14:17:44 +01:00
FrameBox.cpp LibWeb: Omit origin check for content document in FrameBox::paint() 2022-02-16 22:51:25 +00:00
FrameBox.h AK: Rename downcast<T> => verify_cast<T> 2021-06-24 19:57:01 +02:00
ImageBox.cpp LibWeb: Add support for CSS image-rendering property 2022-02-19 11:38:46 +01:00
ImageBox.h LibWeb: Move BrowsingContext into HTML/ 2021-11-18 21:11:30 +01:00
InitialContainingBlock.cpp LibWeb: Always rebuild stacking context tree during layout 2022-02-12 22:30:50 +01:00
InitialContainingBlock.h LibWeb: Rename Layout::BlockBox => BlockContainer 2021-10-06 20:10:36 +02:00
InlineFormattingContext.cpp LibWeb: Allow <input type="button/submit/reset"> to be styled 2022-02-28 15:46:06 +00:00
InlineFormattingContext.h LibWeb: Start making our layout system "transactional" 2022-02-21 18:35:12 +01:00
InlineLevelIterator.cpp LibWeb: Make InlineLevelIterator not enter into inline-block boxes 2022-02-26 09:27:20 +01:00
InlineLevelIterator.h LibWeb: Start making our layout system "transactional" 2022-02-21 18:35:12 +01:00
InlineNode.cpp LibWeb: Paint InlineNode overlay in correct phase, skip pseudo-elements 2022-02-25 19:35:34 +01:00
InlineNode.h LibWeb: Make display: foo box constructors take the Element by pointer 2022-02-25 19:35:34 +01:00
Label.cpp LibWeb: Implement reverse lookup to labels from their labelable nodes 2022-02-16 19:18:57 +01:00
Label.h LibWeb: Support implicit <label> targets 2022-02-15 23:24:41 +01:00
LabelableNode.h Everywhere: Update copyrights with my new serenityos.org e-mail :^) 2022-01-31 18:23:22 +00:00
LayoutPosition.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
LayoutPosition.h Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
LineBox.cpp LibWeb: Use Vector<LineBoxFragment> instead of NonnullOwnPtrVector 2022-02-28 14:17:44 +01:00
LineBox.h LibWeb: Store bottom edge location with each LineBox 2022-02-28 14:17:44 +01:00
LineBoxFragment.cpp LibWeb: Rename InitialContainingBlockBox => InitialContainingBlock 2021-09-08 11:27:46 +02:00
LineBoxFragment.h LibWeb: Use coordinate instead of WeakPtr for box->fragment connection 2022-02-28 14:17:44 +01:00
LineBuilder.cpp LibWeb: Store box's containing line box fragment in FormattingState 2022-02-28 14:17:44 +01:00
LineBuilder.h LibWeb: Start making our layout system "transactional" 2022-02-21 18:35:12 +01:00
ListItemBox.cpp LibWeb: Make display: foo box constructors take the Element by pointer 2022-02-25 19:35:34 +01:00
ListItemBox.h LibWeb: Make display: foo box constructors take the Element by pointer 2022-02-25 19:35:34 +01:00
ListItemMarkerBox.cpp LibWeb: Implement the ::marker pseudo-element 2022-02-25 19:35:34 +01:00
ListItemMarkerBox.h LibWeb: Create list-item markers during layout tree construction 2022-02-21 18:35:12 +01:00
Node.cpp LibWeb: Improve Layout::Box has-definite-size? computation 2022-02-28 14:17:44 +01:00
Node.h LibWeb: Start making our layout system "transactional" 2022-02-21 18:35:12 +01:00
Progress.cpp LibWeb: Add basic implementation of progress bar element 2022-02-16 15:34:08 -05:00
Progress.h LibWeb: Add basic implementation of progress bar element 2022-02-16 15:34:08 -05:00
RadioButton.cpp LibWeb: Make <input type=checkbox> honor the "checked" attribute 2022-02-15 23:24:41 +01:00
RadioButton.h Everywhere: Update copyrights with my new serenityos.org e-mail :^) 2022-01-31 18:23:22 +00:00
ReplacedBox.cpp LibWeb: Remove old Layout::Node::split_into_lines() API 2022-01-23 01:22:41 +01:00
ReplacedBox.h LibWeb: Remove old Layout::Node::split_into_lines() API 2022-01-23 01:22:41 +01:00
SVGBox.cpp LibWeb: Stop treating all SVG elements as inline 2022-02-16 21:47:53 +01:00
SVGBox.h LibWeb: Add const versions of SVGBox::dom_node() and friends 2022-02-11 21:38:27 +01:00
SVGFormattingContext.cpp LibWeb: Add support for 'view-box' attribute to SVGs 2022-02-28 16:49:24 +01:00
SVGFormattingContext.h LibWeb: Start making our layout system "transactional" 2022-02-21 18:35:12 +01:00
SVGGeometryBox.cpp LibWeb: Add support for 'view-box' attribute to SVGs 2022-02-28 16:49:24 +01:00
SVGGeometryBox.h LibWeb: Add support for 'view-box' attribute to SVGs 2022-02-28 16:49:24 +01:00
SVGGraphicsBox.cpp AK: Rename downcast<T> => verify_cast<T> 2021-06-24 19:57:01 +02:00
SVGGraphicsBox.h LibWeb: Add const versions of SVGBox::dom_node() and friends 2022-02-11 21:38:27 +01:00
SVGSVGBox.cpp LibWeb: Give SVG geometry elements a position 2022-02-16 21:47:53 +01:00
SVGSVGBox.h LibWeb: Add SVGFormattingContext to handle SVG box trees 2021-09-18 01:39:59 +02:00
TableBox.cpp LibWeb: Rename Layout::BlockBox => BlockContainer 2021-10-06 20:10:36 +02:00
TableBox.h LibWeb: Rename Layout::BlockBox => BlockContainer 2021-10-06 20:10:36 +02:00
TableCellBox.cpp LibWeb: Remove Layout::Box::width_of_logical_containing_block() 2021-10-27 18:00:51 +02:00
TableCellBox.h LibWeb: Remove Layout::Box::width_of_logical_containing_block() 2021-10-27 18:00:51 +02:00
TableFormattingContext.cpp LibWeb: Compute table cell height after doing its inside layout 2022-02-21 18:35:12 +01:00
TableFormattingContext.h LibWeb: Start making our layout system "transactional" 2022-02-21 18:35:12 +01:00
TableRowBox.cpp Everything: Move to SPDX license identifiers in all files. 2021-04-22 11:22:27 +02:00
TableRowBox.h LibWeb: Start work towards modern CSS "display" values 2021-10-06 19:12:52 +02:00
TableRowGroupBox.cpp LibWeb: Make display: foo box constructors take the Element by pointer 2022-02-25 19:35:34 +01:00
TableRowGroupBox.h LibWeb: Make display: foo box constructors take the Element by pointer 2022-02-25 19:35:34 +01:00
TextNode.cpp LibWeb: Paint full bitmap font glyphs, even if there's overlap 2022-02-26 09:32:52 +01:00
TextNode.h LibWeb: Remove old Layout::Node::split_into_lines() API 2022-01-23 01:22:41 +01:00
TreeBuilder.cpp LibWeb: Implement the ::marker pseudo-element 2022-02-25 19:35:34 +01:00
TreeBuilder.h LibWeb: Add missing headers 2021-10-20 09:20:18 +01:00