RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 09:22:44 +00:00
Code Issues Activity Actions
serenity/Userland/Libraries/LibAudio
History
Timothy Flynn 604d5f5bca AK+Everywhere: Do not implicitly copy variables in TRY macros 
For example, consider cases where we want to propagate errors only in
specific instances:

    auto result = read_data(); // something like ErrorOr<ByteBuffer>
    if (result.is_error() && result.error().code() != EINTR)
        continue;
    auto bytes = TRY(result);

The TRY invocation will currently copy the byte buffer when the
expression (in this case, just a local variable) is stored into
_temporary_result.

This patch binds the expression to a reference to prevent such copies.
In less trival invocations (such as TRY(some_function()), this will
incur only temporary lifetime extensions, i.e. no functional change.
2023-02-10 09:08:52 +00:00
..
CMakeLists.txt Everywhere: Mark dependencies of most targets as PRIVATE 2022-11-01 14:49:09 +00:00
ConnectionToServer.cpp LibCore: Remove try_ prefix from fallible SharedCircularQueue methods 2023-01-28 22:41:36 +01:00
ConnectionToServer.h AK: Remove try_ prefix from FixedArray creation functions 2023-01-28 22:41:36 +01:00
FlacLoader.cpp AK: Remove the fallible constructor from FixedMemoryStream 2023-02-08 17:44:32 +00:00
FlacLoader.h AK: Move memory streams from LibCore 2023-01-29 19:16:44 -07:00
FlacTypes.h LibAudio: Add spec comments to the FlacLoader 2022-06-23 23:16:34 +01:00
GenericTypes.h AK+Everywhere: Rename String to DeprecatedString 2022-12-06 08:54:33 +01:00
Loader.cpp AK: Move Stream and SeekableStream from LibCore 2023-01-29 19:16:44 -07:00
Loader.h AK: Move Stream and SeekableStream from LibCore 2023-01-29 19:16:44 -07:00
LoaderError.h AK+Everywhere: Do not implicitly copy variables in TRY macros 2023-02-10 09:08:52 +00:00
MP3HuffmanTables.h Everywhere: Use ReadonlySpan<T> instead of Span<T const> 2023-02-08 19:15:45 +00:00
MP3Loader.cpp Everywhere: Use ReadonlySpan<T> instead of Span<T const> 2023-02-08 19:15:45 +00:00
MP3Loader.h Everywhere: Use ReadonlySpan<T> instead of Span<T const> 2023-02-08 19:15:45 +00:00
MP3Tables.h LibAudio+LibDSP: Switch samples to 32-bit float instead of 64-bit float 2022-05-07 20:20:16 +02:00
MP3Types.h LibAudio+LibDSP: Switch samples to 32-bit float instead of 64-bit float 2022-05-07 20:20:16 +02:00
Queue.h LibAudio+Userland: Remove Audio::LegacyBuffer 2022-05-03 23:09:20 +02:00
Resampler.h LibAudio: Tolerate a file sample rate lower than the AudioServer's 2022-12-31 00:04:34 +01:00
Sample.h Everywhere: Add sv suffix to strings relying on StringView(char const*) 2022-07-12 23:11:35 +02:00
SampleFormats.cpp AK+Everywhere: Rename String to DeprecatedString 2022-12-06 08:54:33 +01:00
SampleFormats.h AK+Everywhere: Rename String to DeprecatedString 2022-12-06 08:54:33 +01:00
UserSampleQueue.cpp LibAudio: Prevent int overflow in the user buffer queue 2022-12-31 00:08:05 +01:00
UserSampleQueue.h Everywhere: Remove unused includes of AK/Format.h 2023-01-02 20:27:20 -05:00
WavLoader.cpp AK: Remove the fallible constructor from FixedMemoryStream 2023-02-08 17:44:32 +00:00
WavLoader.h AK: Move Stream and SeekableStream from LibCore 2023-01-29 19:16:44 -07:00
WavWriter.cpp AK+Everywhere: Rename String to DeprecatedString 2022-12-06 08:54:33 +01:00
WavWriter.h AK+Everywhere: Rename String to DeprecatedString 2022-12-06 08:54:33 +01:00