RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 12:38:12 +00:00
Code Issues Activity Actions
serenity/Userland/Libraries
History
Nico Weber fe3612ebcb LibPDF: Fix off-by-one in Reader 
With this, looking at page 2 of pdf_reference_1-7.pdf no longer crashes.

Why did it crash in the first place? Because due to this bug, CFF.cpp
failed to parse the font program for the font used to render the `®`
character. `Renderer::render()` adds all errors that are encounterd
to an `errors` object but continues rendering. That meant that the
previous font was still active, and that didn't have a width for that
symbol in its width table.

SimpleFont::draw_string() falls back to get_glyph_width() if there's
no entry for a character for a symbol. `Type1Font::get_glyph_width()`
always dereferences `m_font` in that method, even if the font has
a font program (and m_font is hence nullptr).

With the off-by-one fixed, the second font is successfully installed
as current font, and the second font has a width entry for that symbol,
so the problem no longer occurs.
2023-07-12 14:19:14 -04:00
..
LibArchive LibArchive: Add helper functions for adding members to a ZipOutputStream 2023-07-08 13:14:50 +01:00
LibAudio Everywhere: Remove needless trailing semi-colons after functions 2023-07-08 10:32:56 +01:00
LibC LibC: Fix max value of short 2023-07-08 15:53:02 -04:00
LibCards Everywhere: Remove needless trailing semi-colons after functions 2023-07-08 10:32:56 +01:00
LibChess AK: Add the Input word to input-only buffered streams 2023-05-09 11:18:46 +02:00
LibCMake LibSyntax+Libraries: Replace TextStyle with Gfx::TextAttributes 2023-03-15 14:55:49 +01:00
LibCodeComprehension Everywhere: Remove needless trailing semi-colons after functions 2023-07-08 10:32:56 +01:00
LibCompress Everywhere: Remove needless trailing semi-colons after functions 2023-07-08 10:32:56 +01:00
LibConfig Userland: Convert config listener callbacks to use StringView 2023-06-27 15:37:00 +01:00
LibCore LibCore: Exit EventLoop::spin_until() when exit requested 2023-07-12 05:51:00 +02:00
LibCoredump LibCoredump: Avoid unnecessary conversion to DeprecatedString 2023-05-27 17:30:55 +02:00
LibCpp Everywhere: Remove needless trailing semi-colons after functions 2023-07-08 10:32:56 +01:00
LibCrypt Everywhere: Resolve conflicts with LibC and libc++ 2023-06-27 12:40:38 +02:00
LibCrypto Everywhere: Use nested namespace qualifiers 2023-07-12 10:05:42 +03:30
LibDebug LibDebug: Keep track of the SetEpilogueBegin LineProgram OpCode 2023-06-27 12:40:38 +02:00
LibDesktop Everywhere: Use MonotonicTime instead of Duration 2023-05-24 23:18:07 +02:00
LibDeviceTree Everywhere: Remove unused DeprecatedString includes 2023-04-09 22:00:54 +02:00
LibDiff LibDiff: Add a forwarding header 2023-07-06 13:22:37 +02:00
LibDNS AK: Rename Stream::write_entire_buffer to Stream::write_until_depleted 2023-03-13 15:16:20 +00:00
LibDSP Everywhere: Remove needless trailing semi-colons after functions 2023-07-08 10:32:56 +01:00
LibEDID Everywhere: Use nested namespace qualifiers 2023-07-12 10:05:42 +03:30
LibELF Kernel: Consolidate finding the ELF stack size with validation 2023-07-10 21:08:31 -06:00
LibFileSystem LibFileSystem+Everything: Remove resolve_executable_from_environment 2023-06-06 23:46:36 +02:00
LibFileSystemAccessClient LibFSAC+Userland: Pass options for FSAC::open_file() using a struct 2023-06-11 09:40:17 +01:00
LibGemini Everywhere: Remove needless trailing semi-colons after functions 2023-07-08 10:32:56 +01:00
LibGfx LibGfx/PNGWriter: Use a better limit for scanline capactiy 2023-07-12 07:51:54 +01:00
LibGL Everywhere: Remove needless trailing semi-colons after functions 2023-07-08 10:32:56 +01:00
LibGLSL Everywhere: Use _{short_,}string to create Strings from literals 2023-02-25 20:51:49 +01:00
LibGPU LibGPU: Remove DeprecatedString usage 2023-01-30 13:49:52 -05:00
LibGUI Everywhere: Use nested namespace qualifiers 2023-07-12 10:05:42 +03:30
LibHTTP LibCore: Make NetworkJob::start() take a Stream::BufferedSocketBase& 2023-07-03 23:29:28 +02:00
LibIDL LibIDL: Avoid unnecessary copies of imported paths 2023-06-15 08:09:16 +02:00
LibImageDecoderClient LibImageDecoderClient: Fix minor const-correctness issue 2023-02-21 00:54:04 +01:00
LibIMAP LibCore: Slightly rework the Core::Promise API 2023-07-08 23:13:00 +01:00
LibIPC AK: Introduce UnixDateTime 2023-05-24 23:18:07 +02:00
LibJS LibJS: Add optimized GetGlobal instruction to access global variables 2023-07-12 16:03:16 +02:00
LibKeyboard Everywhere: Remove needless trailing semi-colons after functions 2023-07-08 10:32:56 +01:00
LibLine Everywhere: Use nested namespace qualifiers 2023-07-12 10:05:42 +03:30
LibLocale LibTimeZone+Userland: Change timezone functions to use UnixDateTime 2023-05-24 23:18:07 +02:00
LibMain Everywhere: Explicitly link all binaries against the LibC target 2022-11-01 14:49:09 +00:00
LibManual Everywhere: Remove needless trailing semi-colons after functions 2023-07-08 10:32:56 +01:00
LibMarkdown LibMarkdown: Convert render_to_terminal to String 2023-07-03 02:05:32 +02:00
LibPartition Everywhere: Remove needless trailing semi-colons after functions 2023-07-08 10:32:56 +01:00
LibPCIDB Everywhere: Remove needless trailing semi-colons after functions 2023-07-08 10:32:56 +01:00
LibPDF LibPDF: Fix off-by-one in Reader 2023-07-12 14:19:14 -04:00
LibProtocol Everywhere: Correctly report progress of downloads larger than 4GiB 2023-06-19 06:13:19 +02:00
LibRegex Everywhere: Remove needless trailing semi-colons after functions 2023-07-08 10:32:56 +01:00
LibSanitizer Everywhere: Resolve conflicts with LibC and libc++ 2023-06-27 12:40:38 +02:00
LibSoftGPU LibGfx+Everywhere: Change Gfx::Rect to be endpoint exclusive 2023-05-23 12:35:42 +02:00
LibSQL Everywhere: Remove needless trailing semi-colons after functions 2023-07-08 10:32:56 +01:00
LibSymbolication LibSymbolication: Use Core::File instead of Core::DeprecatedFile 2023-04-27 07:27:14 +02:00
LibSyntax Everywhere: Remove needless trailing semi-colons after functions 2023-07-08 10:32:56 +01:00
LibSystem Everywhere: Resolve conflicts with LibC and libc++ 2023-06-27 12:40:38 +02:00
LibTest Everywhere: Remove needless trailing semi-colons after functions 2023-07-08 10:32:56 +01:00
LibTextCodec LibTextCodec: Add "get output encoding" from the Encoding specification 2023-06-19 06:12:26 +02:00
LibThreading LibCore: Slightly rework the Core::Promise API 2023-07-08 23:13:00 +01:00
LibTimeZone Everywhere: Resolve conflicts with LibC and libc++ 2023-06-27 12:40:38 +02:00
LibTLS LibTLS: Remove unused methods 2023-07-03 23:29:28 +02:00
LibUnicode AK+LibUnicode: Implement String::equals_ignoring_case without allocating 2023-03-08 18:57:53 +00:00
LibUSBDB Everywhere: Remove needless trailing semi-colons after functions 2023-07-08 10:32:56 +01:00
LibVideo Everywhere: Remove needless trailing semi-colons after functions 2023-07-08 10:32:56 +01:00
LibVirtGPU Everywhere: Remove needless trailing semi-colons after functions 2023-07-08 10:32:56 +01:00
LibVT Everywhere: Remove needless trailing semi-colons after functions 2023-07-08 10:32:56 +01:00
LibWasm LibWasm: Implement Element section segment type 4 2023-07-08 15:13:25 +02:00
LibWeb LibWeb: Fix a few comment typos 2023-07-12 17:52:17 +02:00
LibWebSocket AK+Everywhere: Change URL::path() to serialize_path() 2023-04-15 06:37:04 +02:00
LibWebView Browser+LibWebView: Load and Display ARIA Properites and State 2023-07-06 11:21:36 +01:00
LibX86 LibX86: Remove i686 support 2022-12-28 11:53:41 +01:00
LibXML LibXML: Fix parser not leaving self-closing tags 2023-06-17 06:39:21 +02:00
CMakeLists.txt LibFileSystem: Create LibFileSystem 2023-03-21 19:03:21 +00:00