RGBCube/superfreq
1
Fork 0
mirror of https://github.com/RGBCube/superfreq synced 2025-07-27 17:07:44 +00:00
Code Issues Activity

engine: get rid of unnecessary mutex wrapping

Browse source 
AtomicBooll in TurboHystersis already provides thread safety
This commit is contained in:
NotAShelf 2025-05-18 03:33:11 +03:00
parent d671a9c73f
commit 044d6f2fa9
No known key found for this signature in database
GPG key ID: 29D95B64378DB4BF
1 changed files with 8 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/engine.rs
View file

@ -4,8 +4,8 @@ use crate::core::{OperationalMode, SystemReport, TurboSetting};
use crate::cpu::{self}; use crate::cpu::{self};
use crate::util::error::{ControlError, EngineError}; use crate::util::error::{ControlError, EngineError};
use log::{debug, info, warn}; use log::{debug, info, warn};
use std::sync::OnceLock;
use std::sync::atomic::{AtomicBool, Ordering}; use std::sync::atomic::{AtomicBool, Ordering};
use std::sync::{Mutex, OnceLock};
/// A struct to track turbo boost state for AC and battery power modes /// A struct to track turbo boost state for AC and battery power modes
struct TurboHysteresisStates { struct TurboHysteresisStates {
@ -32,12 +32,13 @@ impl TurboHysteresisStates {
} }
} }
/// Create a global instance of `TurboHysteresisStates` protected by a mutex /// Create a global instance of `TurboHysteresisStates` without a mutex
static TURBO_STATES: OnceLock<Mutex<TurboHysteresisStates>> = OnceLock::new(); /// since `AtomicBool` already provides thread safety
static TURBO_STATES: OnceLock<TurboHysteresisStates> = OnceLock::new();
/// Get or initialize the global turbo states /// Get or initialize the global turbo states
fn get_turbo_states() -> &'static Mutex<TurboHysteresisStates> { fn get_turbo_states() -> &'static TurboHysteresisStates {
TURBO_STATES.get_or_init(|| Mutex::new(TurboHysteresisStates::new())) TURBO_STATES.get_or_init(TurboHysteresisStates::new)
} }
/// Manage turbo boost hysteresis state. /// Manage turbo boost hysteresis state.
@ -321,7 +322,7 @@ fn manage_auto_turbo(
// Get the previous state or initialize with the configured initial state // Get the previous state or initialize with the configured initial state
let previous_turbo_enabled = { let previous_turbo_enabled = {
let turbo_states = get_turbo_states().lock().unwrap(); let turbo_states = get_turbo_states();
let hysteresis = turbo_states.get_for_power_state(on_ac_power); let hysteresis = turbo_states.get_for_power_state(on_ac_power);
if let Some(state) = hysteresis.get_previous_state() { if let Some(state) = hysteresis.get_previous_state() {
Some(state) Some(state)
@ -395,7 +396,7 @@ fn manage_auto_turbo(
// Save the current state for next time // Save the current state for next time
{ {
let turbo_states = get_turbo_states().lock().unwrap(); let turbo_states = get_turbo_states();
let hysteresis = turbo_states.get_for_power_state(on_ac_power); let hysteresis = turbo_states.get_for_power_state(on_ac_power);
hysteresis.update_state(enable_turbo); hysteresis.update_state(enable_turbo);
} }