RGBCube/uutils-coreutils
1
Fork 0
mirror of https://github.com/RGBCube/uutils-coreutils synced 2025-07-28 11:37:44 +00:00
Code Issues Activity

shred:add checks for block sizes

Browse source 
This commit adds checks for block size constants. Misconfigured sizes
could lead to overflows or performance issues. While such cases are
expected to be rare or unlikely, it's better to be notified of them
early.
This commit is contained in:
Alexander Shirokov 2025-05-12 10:01:19 +02:00
parent 24d88d777a
commit 14a8f3f3f9
No known key found for this signature in database
GPG key ID: 6020E4D7AFA8ECE7
1 changed files with 8 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/uu/shred/src/shred.rs
View file

@ -514,12 +514,17 @@ fn wipe_file(
}
fn split_on_blocks(file_size: u64, exact: bool) -> (u64, u64) {
// OPTIMAL_IO_BLOCK_SIZE must not exceed BLOCK_SIZE. Violating this may cause overflows due
// to alignment or performance issues.This kind of misconfiguration is
// highly unlikely but would indicate a serious error.
const _: () = assert!(OPTIMAL_IO_BLOCK_SIZE <= BLOCK_SIZE);
let file_size = if exact {
file_size
} else {
// The main idea here is to align the file size to the OPTIMAL_IO_BLOCK_SIZE, and then split it into
// BLOCK_SIZE + remaining bytes. Since the input data is already aligned to N * OPTIMAL_IO_BLOCK_SIZE,
// the output file size will also be aligned and correct.
// The main idea here is to align the file size to the OPTIMAL_IO_BLOCK_SIZE, and then
// split it into BLOCK_SIZE + remaining bytes. Since the input data is already aligned to N
// * OPTIMAL_IO_BLOCK_SIZE, the output file size will also be aligned and correct.
file_size.div_ceil(OPTIMAL_IO_BLOCK_SIZE as u64) * OPTIMAL_IO_BLOCK_SIZE as u64
};
(file_size / BLOCK_SIZE as u64, file_size % BLOCK_SIZE as u64)