RGBCube/uutils-coreutils
1
Fork 0
mirror of https://github.com/RGBCube/uutils-coreutils synced 2025-07-27 19:17:43 +00:00
Code Issues Activity

Replace commented-out code with TODO comments

Browse source
This commit is contained in:
Andrew Liebenow 2024-10-24 13:12:38 -05:00
parent e53dd5ffe1
commit 186d749e94
2 changed files with 4 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/uu/tr/src/operation.rs
View file

@ -324,19 +324,8 @@ impl Sequence {
Ok(ue) => Some(ue), Ok(ue) => Some(ue),
Err(_pa) => { Err(_pa) => {
// TODO // TODO
// Cannot log here, because this closure is executed multiple times // A warning needs to be printed here
// See https://github.com/uutils/coreutils/issues/6821
// let mut last_char = str_to_parse.chars();
// let second_number = last_char.next_back().unwrap();
// let first_number = last_char.as_str();
// show!(USimpleError::new(
// 0,
// format!("warning: the ambiguous octal escape \\{str_to_parse} is being interpreted as the 2-byte sequence \\{first_number}, {second_number}")
// ));
None None
} }
} }

5
tests/by-util/test_tr.rs
View file

@ -1495,9 +1495,8 @@ fn test_multibyte_octal_sequence() {
.pipe_in("(1Ł)") .pipe_in("(1Ł)")
.succeeds() .succeeds()
// TODO // TODO
// Cannot log warning because of how nom is parsing the arguments // A warning needs to be printed here
// .stderr_is(r"tr: warning: the ambiguous octal escape \501 is being interpreted as the 2-byte sequence \50, 1 // See https://github.com/uutils/coreutils/issues/6821
// ")
.stdout_is("Ł)"); .stdout_is("Ł)");
} }