RGBCube/uutils-coreutils
1
Fork 0
mirror of https://github.com/RGBCube/uutils-coreutils synced 2025-07-28 11:37:44 +00:00
Code Issues Activity

uucore: parser: num_parser: Do not Underflow/Overflow when parsing 0

Browse source 
Values like 0e18172487393827593258 and 0e-18172487393827593258 should
just be parsed as 0, and do not need to return an error.
This commit is contained in:
Nicolas Boichat 2025-04-04 12:04:47 +02:00
parent 94a26e170e
commit 1d7e0eccc8
1 changed files with 26 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

28
src/uucore/src/lib/features/parser/num_parser.rs
View file

@ -294,8 +294,14 @@ fn construct_extended_big_decimal<'a>(
scale: u64,
exponent: BigInt,
) -> Result<ExtendedBigDecimal, ExtendedParserError<'a, ExtendedBigDecimal>> {
if digits == BigUint::zero() && negative {
return Ok(ExtendedBigDecimal::MinusZero);
if digits == BigUint::zero() {
// Return return 0 if the digits are zero. In particular, we do not ever
// return Overflow/Underflow errors in that case.
return Ok(if negative {
ExtendedBigDecimal::MinusZero
} else {
ExtendedBigDecimal::zero()
});
}
let sign = if negative { Sign::Minus } else { Sign::Plus };
@ -712,6 +718,24 @@ mod tests {
ExtendedBigDecimal::MinusZero
))
));
// But no Overflow/Underflow if the digits are 0.
assert_eq!(
ExtendedBigDecimal::extended_parse(&format!("0e{}", i64::MAX as u64 + 2)),
Ok(ExtendedBigDecimal::zero()),
);
assert_eq!(
ExtendedBigDecimal::extended_parse(&format!("-0.0e{}", i64::MAX as u64 + 3)),
Ok(ExtendedBigDecimal::MinusZero)
);
assert_eq!(
ExtendedBigDecimal::extended_parse(&format!("0.0000e{}", i64::MIN)),
Ok(ExtendedBigDecimal::zero()),
);
assert_eq!(
ExtendedBigDecimal::extended_parse(&format!("-0e{}", i64::MIN + 2)),
Ok(ExtendedBigDecimal::MinusZero)
);
}
#[test]