Consolidate lint management with workspaces

At the moment, most crates rely on build scripts and other methods to keep lint-consistency. As of recent, Rust can use workspaces to globally set all the lint configurations.

This PR only adds lint configuration to each crate, but it does not introduce any changes to the code or lint configuration. In the subsequent PRs, I plan to gradually move lints from `uucore` to workspace, making all code consistent.

Note that `seq` relies on a custom lint config - which means its configuration may need to be managed by hand until Cargo introduces per-crate overrides.

Cargo.toml

@@ -584,3 +584,13 @@ manual_let_else = "warn"
 all = { level = "deny", priority = -1 }
 cargo = { level = "warn", priority = -1 }
 pedantic = { level = "deny", priority = -1 }
+
+# This is the linting configuration for all crates.
+# Eventually the clippy settings from the `[lints]` section should be moved here.
+# In order to use these, all crates have `[lints] workspace = true` section.
+[workspace.lints.rust]
+# unused_qualifications = "warn"
+
+[workspace.lints.clippy]
+all = { level = "deny", priority = -1 }
+#cargo = { level = "warn", priority = -1 }

src/uu/arch/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/arch.rs"
 

src/uu/base32/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/base32.rs"
 

src/uu/base64/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/base64.rs"
 

src/uu/basename/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/basename.rs"
 

src/uu/basenc/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/basenc.rs"
 

src/uu/cat/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/cat.rs"
 

src/uu/chcon/Cargo.toml

@@ -12,6 +12,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/chcon.rs"
 

src/uu/chgrp/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/chgrp.rs"
 

src/uu/chmod/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/chmod.rs"
 

src/uu/chown/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/chown.rs"
 

src/uu/chroot/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/chroot.rs"
 

src/uu/cksum/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/cksum.rs"
 

src/uu/comm/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/comm.rs"
 

src/uu/cp/Cargo.toml

@@ -17,6 +17,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/cp.rs"
 

src/uu/csplit/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/csplit.rs"
 

src/uu/cut/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/cut.rs"
 

src/uu/date/Cargo.toml

@@ -14,6 +14,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/date.rs"
 

src/uu/dd/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/dd.rs"
 

src/uu/df/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/df.rs"
 

src/uu/dir/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/dir.rs"
 

src/uu/dircolors/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/dircolors.rs"
 

src/uu/dirname/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/dirname.rs"
 

src/uu/du/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/du.rs"
 

src/uu/echo/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/echo.rs"
 

src/uu/env/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/env.rs"
 

src/uu/expand/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/expand.rs"
 

src/uu/expr/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/expr.rs"
 

src/uu/factor/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [build-dependencies]
 num-traits = { workspace = true } # used in src/numerics.rs, which is included by build.rs
 

src/uu/false/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/false.rs"
 

src/uu/fmt/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/fmt.rs"
 

src/uu/fold/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/fold.rs"
 

src/uu/groups/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/groups.rs"
 

src/uu/hashsum/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/hashsum.rs"
 

src/uu/head/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/head.rs"
 

src/uu/hostid/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/hostid.rs"
 

src/uu/hostname/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/hostname.rs"
 

src/uu/id/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/id.rs"
 

src/uu/install/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/install.rs"
 

src/uu/join/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/join.rs"
 

src/uu/kill/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/kill.rs"
 

src/uu/link/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/link.rs"
 

src/uu/ln/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/ln.rs"
 

src/uu/logname/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/logname.rs"
 

src/uu/ls/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/ls.rs"
 

src/uu/mkdir/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/mkdir.rs"
 

src/uu/mkfifo/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/mkfifo.rs"
 

src/uu/mknod/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 name = "uu_mknod"
 path = "src/mknod.rs"

src/uu/mktemp/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/mktemp.rs"
 

src/uu/more/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/more.rs"
 

src/uu/mv/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/mv.rs"
 

src/uu/nice/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/nice.rs"
 

src/uu/nl/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/nl.rs"
 

src/uu/nohup/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/nohup.rs"
 

src/uu/nproc/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/nproc.rs"
 

src/uu/numfmt/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/numfmt.rs"
 

src/uu/od/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/od.rs"
 

src/uu/paste/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/paste.rs"
 

src/uu/pathchk/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/pathchk.rs"
 

src/uu/pinky/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/pinky.rs"
 

src/uu/pr/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/pr.rs"
 

src/uu/printenv/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/printenv.rs"
 

src/uu/printf/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/printf.rs"
 

src/uu/ptx/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/ptx.rs"
 

src/uu/pwd/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/pwd.rs"
 

src/uu/readlink/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/readlink.rs"
 

src/uu/realpath/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/realpath.rs"
 

src/uu/rm/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/rm.rs"
 

src/uu/rmdir/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/rmdir.rs"
 

src/uu/runcon/Cargo.toml

@@ -12,6 +12,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/runcon.rs"
 

src/uu/seq/Cargo.toml

@@ -34,6 +34,11 @@ uucore = { workspace = true, features = [
 name = "seq"
 path = "src/main.rs"
 
+# FIXME: this is the only crate that has a separate lints configuration,
+#        which for now means a full copy of all clippy and rust lints here.
+[lints.clippy]
+all = { level = "deny", priority = -1 }
+
 # Allow "fuzzing" as a "cfg" condition name
 # https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html
 [lints.rust]

src/uu/shred/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/shred.rs"
 

src/uu/shuf/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/shuf.rs"
 

src/uu/sleep/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/sleep.rs"
 

src/uu/sort/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/sort.rs"
 

src/uu/split/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/split.rs"
 

src/uu/stat/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/stat.rs"
 

src/uu/stdbuf/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/stdbuf.rs"
 

src/uu/stty/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/stty.rs"
 

src/uu/sum/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/sum.rs"
 

src/uu/sync/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/sync.rs"
 

src/uu/tac/Cargo.toml

@@ -15,6 +15,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/tac.rs"
 

src/uu/tail/Cargo.toml

@@ -14,6 +14,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/tail.rs"
 

src/uu/tee/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/tee.rs"
 

src/uu/test/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/test.rs"
 

src/uu/timeout/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/timeout.rs"
 

src/uu/touch/Cargo.toml

@@ -14,6 +14,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/touch.rs"
 

src/uu/tr/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/tr.rs"
 

src/uu/true/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/true.rs"
 

src/uu/truncate/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/truncate.rs"
 

src/uu/tsort/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/tsort.rs"
 

src/uu/tty/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/tty.rs"
 

src/uu/uname/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/uname.rs"
 

src/uu/unexpand/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/unexpand.rs"
 

src/uu/uniq/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/uniq.rs"
 

src/uu/unlink/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/unlink.rs"
 

src/uu/uptime/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/uptime.rs"
 

src/uu/users/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/users.rs"
 

src/uu/vdir/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/vdir.rs"
 

src/uu/wc/Cargo.toml

@@ -13,6 +13,9 @@ edition = "2024"
 
 readme.workspace = true
 
+[lints]
+workspace = true
+
 [lib]
 path = "src/wc.rs"