From 27b7552ef4a8986b0e931718563021ee7270fc22 Mon Sep 17 00:00:00 2001
From: Yagiz Degirmenci <62724709+ycd@users.noreply.github.com>
Date: Mon, 22 Mar 2021 12:01:54 +0300
Subject: [PATCH] fix(tail): add support for negative indexing (#1865)

closes: https://github.com/uutils/coreutils/issues/1860
---
 src/uu/tail/src/tail.rs    |  6 ++++--
 tests/by-util/test_tail.rs | 14 ++++++++++++++
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/src/uu/tail/src/tail.rs b/src/uu/tail/src/tail.rs
index cd391a53e..3a6b04b29 100644
--- a/src/uu/tail/src/tail.rs
+++ b/src/uu/tail/src/tail.rs
@@ -80,6 +80,7 @@ pub fn uumain(args: impl uucore::Args) -> i32 {
                 .short("c")
                 .long(options::BYTES)
                 .takes_value(true)
+                .allow_hyphen_values(true)
                 .help("Number of bytes to print"),
         )
         .arg(
@@ -93,6 +94,7 @@ pub fn uumain(args: impl uucore::Args) -> i32 {
                 .short("n")
                 .long(options::LINES)
                 .takes_value(true)
+                .allow_hyphen_values(true)
                 .help("Number of lines to print"),
         )
         .arg(
@@ -343,9 +345,9 @@ pub fn parse_size(mut size_slice: &str) -> Result<u64, ParseSizeErr> {
         // sole B is not a valid suffix
         Err(ParseSizeErr::parse_failure(size_slice))
     } else {
-        let value: Option<u64> = size_slice.parse().ok();
+        let value: Option<i64> = size_slice.parse().ok();
         value
-            .map(|v| Ok(multiplier * v))
+            .map(|v| Ok((multiplier as i64 * v.abs()) as u64))
             .unwrap_or_else(|| Err(ParseSizeErr::parse_failure(size_slice)))
     }
 }
diff --git a/tests/by-util/test_tail.rs b/tests/by-util/test_tail.rs
index 458fc6aa7..5edff4d55 100644
--- a/tests/by-util/test_tail.rs
+++ b/tests/by-util/test_tail.rs
@@ -329,3 +329,17 @@ fn test_multiple_input_quiet_flag_overrides_verbose_flag_for_suppressing_headers
         .run()
         .stdout_is_fixture("foobar_multiple_quiet.expected");
 }
+
+#[test]
+fn test_negative_indexing() {
+    let positive_lines_index = new_ucmd!().arg("-n").arg("5").arg(FOOBAR_TXT).run();
+
+    let negative_lines_index = new_ucmd!().arg("-n").arg("-5").arg(FOOBAR_TXT).run();
+
+    let positive_bytes_index = new_ucmd!().arg("-c").arg("20").arg(FOOBAR_TXT).run();
+
+    let negative_bytes_index = new_ucmd!().arg("-c").arg("-20").arg(FOOBAR_TXT).run();
+
+    assert_eq!(positive_lines_index.stdout, negative_lines_index.stdout);
+    assert_eq!(positive_bytes_index.stdout, negative_bytes_index.stdout);
+}