1
Fork 0
mirror of https://github.com/RGBCube/uutils-coreutils synced 2025-07-28 03:27:44 +00:00

tail: Implement tail -z.

This options makes tail use NULL instead of newline as a line
delimiter.
This commit is contained in:
Valentin Lorentz 2016-04-02 12:32:33 +02:00
parent 9e5a2400be
commit 2fd7164cda
4 changed files with 25 additions and 10 deletions

View file

@ -28,7 +28,7 @@ static VERSION: &'static str = env!("CARGO_PKG_VERSION");
enum FilterMode { enum FilterMode {
Bytes(usize), Bytes(usize),
Lines(usize), Lines(usize, u8), // (number of lines, delimiter)
} }
struct Settings { struct Settings {
@ -41,7 +41,7 @@ struct Settings {
impl Default for Settings { impl Default for Settings {
fn default() -> Settings { fn default() -> Settings {
Settings { Settings {
mode: FilterMode::Lines(10), mode: FilterMode::Lines(10, '\n' as u8),
sleep_msec: 1000, sleep_msec: 1000,
beginning: false, beginning: false,
follow: false, follow: false,
@ -54,7 +54,7 @@ pub fn uumain(args: Vec<String>) -> i32 {
// handle obsolete -number syntax // handle obsolete -number syntax
let options = match obsolete(&args[1..]) { let options = match obsolete(&args[1..]) {
(args, Some(n)) => { settings.mode = FilterMode::Lines(n); args }, (args, Some(n)) => { settings.mode = FilterMode::Lines(n, '\n' as u8); args },
(args, None) => args (args, None) => args
}; };
@ -66,6 +66,7 @@ pub fn uumain(args: Vec<String>) -> i32 {
opts.optopt("n", "lines", "Number of lines to print", "k"); opts.optopt("n", "lines", "Number of lines to print", "k");
opts.optflag("f", "follow", "Print the file as it grows"); opts.optflag("f", "follow", "Print the file as it grows");
opts.optopt("s", "sleep-interval", "Number or seconds to sleep between polling the file when running with -f", "n"); opts.optopt("s", "sleep-interval", "Number or seconds to sleep between polling the file when running with -f", "n");
opts.optflag("z", "zero-terminated", "Line delimiter is NUL, not newline");
opts.optflag("h", "help", "help"); opts.optflag("h", "help", "help");
opts.optflag("V", "version", "version"); opts.optflag("V", "version", "version");
@ -105,7 +106,7 @@ pub fn uumain(args: Vec<String>) -> i32 {
slice = &slice[1..]; slice = &slice[1..];
} }
match parse_size(slice) { match parse_size(slice) {
Some(m) => settings.mode = FilterMode::Lines(m), Some(m) => settings.mode = FilterMode::Lines(m, '\n' as u8),
None => { None => {
show_error!("invalid number of lines ({})", slice); show_error!("invalid number of lines ({})", slice);
return 1; return 1;
@ -131,6 +132,12 @@ pub fn uumain(args: Vec<String>) -> i32 {
} }
}; };
if given_options.opt_present("z") {
if let FilterMode::Lines(count, _) = settings.mode {
settings.mode = FilterMode::Lines(count, 0);
}
}
let files = given_options.free; let files = given_options.free;
if files.is_empty() { if files.is_empty() {
@ -269,7 +276,7 @@ fn follow<T: Read>(mut reader: BufReader<T>, settings: &Settings) {
/// Iterate over bytes in the file, in reverse, until `should_stop` returns /// Iterate over bytes in the file, in reverse, until `should_stop` returns
/// true. The `file` is left seek'd to the position just after the byte that /// true. The `file` is left seek'd to the position just after the byte that
/// `should_stop` returned true for. /// `should_stop` returned true for.
fn backwards_thru_file<F>(file: &mut File, size: u64, buf: &mut Vec<u8>, should_stop: &mut F) fn backwards_thru_file<F>(file: &mut File, size: u64, buf: &mut Vec<u8>, delimiter: u8, should_stop: &mut F)
where F: FnMut(u8) -> bool where F: FnMut(u8) -> bool
{ {
assert!(buf.len() >= BLOCK_SIZE as usize); assert!(buf.len() >= BLOCK_SIZE as usize);
@ -295,7 +302,7 @@ fn backwards_thru_file<F>(file: &mut File, size: u64, buf: &mut Vec<u8>, should_
let slice = &buf[0..(block_size as usize)]; let slice = &buf[0..(block_size as usize)];
for (i, ch) in slice.iter().enumerate().rev() { for (i, ch) in slice.iter().enumerate().rev() {
// Ignore one trailing newline. // Ignore one trailing newline.
if block_idx == 0 && i as u64 == block_size - 1 && *ch == ('\n' as u8) { if block_idx == 0 && i as u64 == block_size - 1 && *ch == delimiter {
continue; continue;
} }
@ -326,9 +333,9 @@ fn bounded_tail(mut file: File, settings: &Settings) {
// Find the position in the file to start printing from. // Find the position in the file to start printing from.
match settings.mode { match settings.mode {
FilterMode::Lines(mut count) => { FilterMode::Lines(mut count, delimiter) => {
backwards_thru_file(&mut file, size, &mut buf, &mut |byte| { backwards_thru_file(&mut file, size, &mut buf, delimiter, &mut |byte| {
if byte == ('\n' as u8) { if byte == delimiter {
count -= 1; count -= 1;
count == 0 count == 0
} else { } else {
@ -367,7 +374,7 @@ fn unbounded_tail<T: Read>(mut reader: BufReader<T>, settings: &Settings) {
// contains count lines/chars. When reaching the end of file, output the // contains count lines/chars. When reaching the end of file, output the
// data in the ringbuf. // data in the ringbuf.
match settings.mode { match settings.mode {
FilterMode::Lines(mut count) => { FilterMode::Lines(mut count, _delimiter) => {
let mut ringbuf: VecDeque<String> = VecDeque::new(); let mut ringbuf: VecDeque<String> = VecDeque::new();
let mut skip = if settings.beginning { let mut skip = if settings.beginning {
let temp = count; let temp = count;

BIN
tests/fixtures/tail/foobar_with_null.txt vendored Normal file

Binary file not shown.

Binary file not shown.

View file

@ -8,6 +8,7 @@ use common::util::*;
static UTIL_NAME: &'static str = "tail"; static UTIL_NAME: &'static str = "tail";
static FOOBAR_TXT: &'static str = "foobar.txt"; static FOOBAR_TXT: &'static str = "foobar.txt";
static FOOBAR_WITH_NULL_TXT: &'static str = "foobar_with_null.txt";
#[test] #[test]
fn test_stdin_default() { fn test_stdin_default() {
@ -30,6 +31,13 @@ fn test_n_greater_than_number_of_lines() {
assert_eq!(result.stdout, at.read(FOOBAR_TXT)); assert_eq!(result.stdout, at.read(FOOBAR_TXT));
} }
#[test]
fn test_null_default() {
let (at, mut ucmd) = testing(UTIL_NAME);
let result = ucmd.arg("-z").arg(FOOBAR_WITH_NULL_TXT).run();
assert_eq!(result.stdout, at.read("foobar_with_null_default.expected"));
}
#[test] #[test]
fn test_single_big_args() { fn test_single_big_args() {
const FILE: &'static str = "single_big_args.txt"; const FILE: &'static str = "single_big_args.txt";