RGBCube/uutils-coreutils
1
Fork 0
mirror of https://github.com/RGBCube/uutils-coreutils synced 2025-08-02 05:57:46 +00:00
Code Issues Activity

factor::miller_rabin::is_prime: Fix bug

Browse source 
Montgomery<_> only works for odd n, so attempting to construct an instance
for an even number results in a panic!

The most obvious solution is to special-case even numbers.
This commit is contained in:
nicoo 2020-07-04 12:58:09 +02:00
parent d2b43f49f9
commit 308290325a
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/uu/factor/src/miller_rabin.rs
View file

@ -101,10 +101,14 @@ pub(crate) fn test<A: Arithmetic + Basis>(m: A) -> Result {
Prime
}
// Used by build.rs' tests
// Used by build.rs' tests and debug assertions
#[allow(dead_code)]
pub(crate) fn is_prime(n: u64) -> bool {
test::<Montgomery<u64>>(Montgomery::new(n)).is_prime()
if n % 2 == 0 {
n == 2
} else {
test::<Montgomery<u64>>(Montgomery::new(n)).is_prime()
}
}
#[cfg(test)]