RGBCube/uutils-coreutils
1
Fork 0
mirror of https://github.com/RGBCube/uutils-coreutils synced 2025-07-31 13:07:46 +00:00
Code Issues Activity

mkdir: correctly set umask so that tests fail without the fix

Browse source
This commit is contained in:
John Shin 2023-05-21 19:31:04 -07:00
parent 9e8575dadd
commit 33ac653ce5
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
tests/by-util/test_mkdir.rs
View file

@ -76,7 +76,7 @@ fn test_mkdir_dup_dir_parent() {
fn test_mkdir_parent_mode() { fn test_mkdir_parent_mode() {
let (at, mut ucmd) = at_and_ucmd!(); let (at, mut ucmd) = at_and_ucmd!();
let default_umask: mode_t = 0o022; let default_umask: mode_t = 0o160;
let original_umask = unsafe { umask(default_umask) }; let original_umask = unsafe { umask(default_umask) };
ucmd.arg("-p").arg("a/b").succeeds().no_stderr().no_stdout(); ucmd.arg("-p").arg("a/b").succeeds().no_stderr().no_stdout();
@ -104,11 +104,11 @@ fn test_mkdir_parent_mode() {
fn test_mkdir_parent_mode_check_existing_parent() { fn test_mkdir_parent_mode_check_existing_parent() {
let (at, mut ucmd) = at_and_ucmd!(); let (at, mut ucmd) = at_and_ucmd!();
let default_umask: mode_t = 0o022;
let original_umask = unsafe { umask(default_umask) };
at.mkdir("a"); at.mkdir("a");
let default_umask: mode_t = 0o160;
let original_umask = unsafe { umask(default_umask) };
ucmd.arg("-p") ucmd.arg("-p")
.arg("a/b/c") .arg("a/b/c")
.succeeds() .succeeds()
@ -119,7 +119,7 @@ fn test_mkdir_parent_mode_check_existing_parent() {
// parent dirs that already exist do not get their permissions modified // parent dirs that already exist do not get their permissions modified
assert_eq!( assert_eq!(
at.metadata("a").permissions().mode() as mode_t, at.metadata("a").permissions().mode() as mode_t,
(!default_umask & 0o777) + 0o40000 (!original_umask & 0o777) + 0o40000
); );
assert!(at.dir_exists("a/b")); assert!(at.dir_exists("a/b"));
assert_eq!( assert_eq!(