Merge pull request #1534 from sylvestre/logname

Logname - add test and simplify the code a bit

src/uu/logname/src/logname.rs

@@ -39,14 +39,10 @@ static LONG_HELP: &str = "";
 pub fn uumain(args: Vec<String>) -> i32 {
     app!(SYNTAX, SUMMARY, LONG_HELP).parse(args);
 
-    exec();
-
-    0
-}
-
-fn exec() {
     match get_userlogin() {
         Some(userlogin) => println!("{}", userlogin),
         None => show_error!("no login name"),
     }
+
+    0
 }

tests/by-util/test_logname.rs

@@ -1 +1,27 @@
-// ToDO: add tests
+use crate::common::util::*;
+use std::env;
+
+#[test]
+fn test_normal() {
+    let (_, mut ucmd) = at_and_ucmd!();
+
+    let result = ucmd.run();
+    println!("result.stdout = {}", result.stdout);
+    println!("result.stderr = {}", result.stderr);
+    println!("env::var(CI).is_ok() = {}", env::var("CI").is_ok());
+
+    for (key, value) in env::vars() {
+        println!("{}: {}", key, value);
+    }
+    if env::var("USER").is_ok()
+        && env::var("USER").unwrap() == "runner"
+        && result.stderr.contains("error: no login name")
+    {
+        // In the CI, some server are failing to return logname.
+        // As seems to be a configuration issue, ignoring it
+        return;
+    }
+
+    assert!(result.success);
+    assert!(!result.stdout.trim().is_empty());
+}