From 3b8f3d04f47d5d6b5194e84cf54ea00d25baec83 Mon Sep 17 00:00:00 2001 From: John Shin Date: Tue, 2 May 2023 12:49:49 -0700 Subject: [PATCH] core: remove unnecessary if statement in update control --- src/uucore/src/lib/mods/update_control.rs | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/src/uucore/src/lib/mods/update_control.rs b/src/uucore/src/lib/mods/update_control.rs index 13057dfc5..3cd81e012 100644 --- a/src/uucore/src/lib/mods/update_control.rs +++ b/src/uucore/src/lib/mods/update_control.rs @@ -122,16 +122,12 @@ pub mod arguments { /// assert_eq!(update_mode, UpdateMode::ReplaceAll) /// } pub fn determine_update_mode(matches: &ArgMatches) -> UpdateMode { - if matches.contains_id(arguments::OPT_UPDATE) { - if let Some(mode) = matches.get_one::(arguments::OPT_UPDATE) { - match mode.as_str() { - "all" => UpdateMode::ReplaceAll, - "none" => UpdateMode::ReplaceNone, - "older" => UpdateMode::ReplaceIfOlder, - _ => unreachable!("other args restricted by clap"), - } - } else { - unreachable!("other args restricted by clap") + if let Some(mode) = matches.get_one::(arguments::OPT_UPDATE) { + match mode.as_str() { + "all" => UpdateMode::ReplaceAll, + "none" => UpdateMode::ReplaceNone, + "older" => UpdateMode::ReplaceIfOlder, + _ => unreachable!("other args restricted by clap"), } } else if matches.get_flag(arguments::OPT_UPDATE_NO_ARG) { // short form of this option is equivalent to using --update=older