From 4052d4ec6a3c7dbcc5e81ddc54c544d3717d5797 Mon Sep 17 00:00:00 2001 From: electricboogie <32370782+electricboogie@users.noreply.github.com> Date: Sat, 8 Jan 2022 12:10:52 -0600 Subject: [PATCH] Add test for double printing dangling link errors --- tests/by-util/test_ls.rs | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/tests/by-util/test_ls.rs b/tests/by-util/test_ls.rs index 0cb6d8a81..82c5a4318 100644 --- a/tests/by-util/test_ls.rs +++ b/tests/by-util/test_ls.rs @@ -56,8 +56,8 @@ fn test_ls_ordering() { .stdout_matches(&Regex::new("some-dir1:\\ntotal 0").unwrap()); } -#[cfg(all(feature = "chmod"))] #[test] +#[cfg(feature = "chmod")] fn test_ls_io_errors() { let scene = TestScenario::new(util_name!()); let at = &scene.fixtures; @@ -105,6 +105,16 @@ fn test_ls_io_errors() { .stderr_contains("cannot open directory") .stderr_contains("Permission denied") .stdout_contains("some-dir4"); + + // test we don't double print on dangling link metadata errors + scene + .ucmd() + .arg("-iRL") + .arg("some-dir2") + .fails() + .stderr_does_not_contain( + "ls: cannot access 'some-dir2/dangle': No such file or directory\nls: cannot access 'some-dir2/dangle': No such file or directory" + ); } #[test]