RGBCube/uutils-coreutils
1
Fork 0
mirror of https://github.com/RGBCube/uutils-coreutils synced 2025-07-28 11:37:44 +00:00
Code Issues Activity

Merge pull request #6032 from RenjiSann/feature/printf-0c-error

Browse source 
printf: '%0c' and '%0s' should fail
This commit is contained in:
Daniel Hofstetter 2024-03-01 09:25:33 +01:00 • committed by GitHub
commit 41f809de98
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 14 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/uucore/src/lib/features/format/spec.rs
View file

@ -171,7 +171,7 @@ impl Spec {
Ok(match type_spec { Ok(match type_spec {
// GNU accepts minus, plus and space even though they are not used // GNU accepts minus, plus and space even though they are not used
b'c' => { b'c' => {
if flags.hash || precision.is_some() { if flags.zero || flags.hash || precision.is_some() {
return Err(&start[..index]); return Err(&start[..index]);
} }
Self::Char { Self::Char {
@ -180,7 +180,7 @@ impl Spec {
} }
} }
b's' => { b's' => {
if flags.hash { if flags.zero || flags.hash {
return Err(&start[..index]); return Err(&start[..index]);
} }
Self::String { Self::String {

12
tests/by-util/test_printf.rs
View file

@ -765,3 +765,15 @@ fn pad_string() {
.stdout_only(expected); .stdout_only(expected);
} }
} }
#[test]
fn format_spec_zero_char_fails() {
// It is invalid to have the format spec '%0c'
new_ucmd!().args(&["%0c", "3"]).fails().code_is(1);
}
#[test]
fn format_spec_zero_string_fails() {
// It is invalid to have the format spec '%0s'
new_ucmd!().args(&["%0s", "3"]).fails().code_is(1);
}