From 4cb749024627f10b7fe9357792f32b426edf289e Mon Sep 17 00:00:00 2001 From: Daniel Hofstetter Date: Mon, 9 Jun 2025 15:41:22 +0200 Subject: [PATCH] tr: use "sets_len == 1" instead of "sets_len < 2" because sets_len can never be 0 --- src/uu/tr/src/tr.rs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/uu/tr/src/tr.rs b/src/uu/tr/src/tr.rs index 17f893006..422cf972a 100644 --- a/src/uu/tr/src/tr.rs +++ b/src/uu/tr/src/tr.rs @@ -47,13 +47,13 @@ pub fn uumain(args: impl uucore::Args) -> UResult<()> { .map(ToOwned::to_owned) .collect(); - let sets_len = sets.len(); - if sets.is_empty() { return Err(UUsageError::new(1, get_message("tr-error-missing-operand"))); } - if !(delete_flag || squeeze_flag) && sets_len < 2 { + let sets_len = sets.len(); + + if !(delete_flag || squeeze_flag) && sets_len == 1 { return Err(UUsageError::new( 1, get_message_with_args( @@ -63,7 +63,7 @@ pub fn uumain(args: impl uucore::Args) -> UResult<()> { )); } - if delete_flag & squeeze_flag && sets_len < 2 { + if delete_flag & squeeze_flag && sets_len == 1 { return Err(UUsageError::new( 1, get_message_with_args( @@ -143,7 +143,7 @@ pub fn uumain(args: impl uucore::Args) -> UResult<()> { translate_input(&mut locked_stdin, &mut buffered_stdout, op)?; } } else if squeeze_flag { - if sets_len < 2 { + if sets_len == 1 { let op = SqueezeOperation::new(set1); translate_input(&mut locked_stdin, &mut buffered_stdout, op)?; } else {