From 1337c6f174d6364e9d642c956c93963954eb6427 Mon Sep 17 00:00:00 2001 From: Sylvestre Ledru Date: Sun, 22 Dec 2024 12:52:05 +0100 Subject: [PATCH 1/2] Try to report no longer SKIP --- .github/workflows/GnuTests.yml | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/.github/workflows/GnuTests.yml b/.github/workflows/GnuTests.yml index 04b487f5c..bba5de96c 100644 --- a/.github/workflows/GnuTests.yml +++ b/.github/workflows/GnuTests.yml @@ -249,11 +249,15 @@ jobs: CURRENT_RUN_ERROR=$(sed -n "s/^ERROR: \([[:print:]]\+\).*/\1/p" "${new_log_file}" | sort) REF_FAILING=$(sed -n "s/^FAIL: \([[:print:]]\+\).*/\1/p" "${ref_log_file}"| sort) CURRENT_RUN_FAILING=$(sed -n "s/^FAIL: \([[:print:]]\+\).*/\1/p" "${new_log_file}" | sort) - echo "Detailled information:" + REF_SKIP=$(sed -n "s/^SKIP: \([[:print:]]\+\).*/\1/p" "${ref_log_file}"| sort) + CURRENT_RUN_SKIP=$(sed -n "s/^SKIP: \([[:print:]]\+\).*/\1/p" "${new_log_file}" | sort) + + echo "Detailed information:" echo "REF_ERROR = ${REF_ERROR}" echo "CURRENT_RUN_ERROR = ${CURRENT_RUN_ERROR}" echo "REF_FAILING = ${REF_FAILING}" echo "CURRENT_RUN_FAILING = ${CURRENT_RUN_FAILING}" + echo "REF_SKIP_PASS = ${REF_SKIP}" # Compare failing and error tests for LINE in ${CURRENT_RUN_FAILING} @@ -313,6 +317,17 @@ jobs: echo $MSG >> ${COMMENT_LOG} fi done + + for LINE in ${REF_SKIP} + do + if ! grep -Fxq ${LINE}<<<"${CURRENT_RUN_SKIP}" + then + MSG="Congrats! The gnu test ${LINE} is no longer SKIP! (might be PASS, ERROR or FAIL)" + echo "::warning ::$MSG" + echo $MSG >> ${COMMENT_LOG} + fi + done + else echo "::warning ::Skipping ${test_type} test failure comparison; no prior reference test logs are available." fi From b1d4e1b8128167ba5dc78ce749609456ed38463a Mon Sep 17 00:00:00 2001 From: Sylvestre Ledru Date: Sun, 22 Dec 2024 14:12:57 +0100 Subject: [PATCH 2/2] gnu comment: explain what might be the state --- .github/workflows/GnuTests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/GnuTests.yml b/.github/workflows/GnuTests.yml index bba5de96c..ab973defc 100644 --- a/.github/workflows/GnuTests.yml +++ b/.github/workflows/GnuTests.yml @@ -312,7 +312,7 @@ jobs: do if ! grep -Fxq ${LINE}<<<"${CURRENT_RUN_ERROR}" then - MSG="Congrats! The gnu test ${LINE} is no longer ERROR!" + MSG="Congrats! The gnu test ${LINE} is no longer ERROR! (might be PASS or FAIL)" echo "::warning ::$MSG" echo $MSG >> ${COMMENT_LOG} fi