From 55be34a2c4de46d535b443b56dcd72c1e4f752fb Mon Sep 17 00:00:00 2001 From: Keunwoo Lee Date: Sun, 25 Jan 2015 22:21:38 -0800 Subject: [PATCH] od: clean up fname usage + rm superfluous clone + rm superfluous mut variable --- src/od/od.rs | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/od/od.rs b/src/od/od.rs index 58c61416e..6766dc664 100644 --- a/src/od/od.rs +++ b/src/od/od.rs @@ -51,18 +51,17 @@ pub fn uumain(args: Vec) -> isize { Err(f) => { panic!("Invalid -A/--address-radix\n{}", f) } }; - let mut fname; - match args.last() { - Some(n) => fname = n, - None => { panic!("Need fname for now") ; } + let fname = match args.last() { + Some(n) => n, + None => { panic!("Need fname for now") ; } }; - main(input_offset_base, fname.clone()); + main(input_offset_base, fname.as_slice()); 0 } -fn main(input_offset_base: Radix, fname: String) { +fn main(input_offset_base: Radix, fname: &str) { let mut f = match File::open(&Path::new(fname)) { Ok(f) => f, Err(e) => panic!("file error: {}", e)