RGBCube/uutils-coreutils
1
Fork 0
mirror of https://github.com/RGBCube/uutils-coreutils synced 2025-07-29 03:57:44 +00:00
Code Issues Activity

Get number of bytes to drain in a safer way

Browse source
This commit is contained in:
Andrew Liebenow 2024-09-21 10:31:43 -05:00
parent 8a6923dcd4
commit 5cd050665d
1 changed files with 5 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/uu/base32/src/base_common.rs
View file

@ -364,14 +364,13 @@ mod fast_encode {
let make_contiguous_result = encoded_buffer.make_contiguous();
// How many bytes to take from the front of `encoded_buffer` and then write to stdout
// (Number of whole lines times the line length)
let number_of_bytes_to_drain =
(make_contiguous_result.len() / line_length_usize) * line_length_usize;
let chunks_exact = make_contiguous_result.chunks_exact(line_length_usize);
let mut bytes_added_to_print_buffer = 0_usize;
for sl in chunks_exact {
bytes_added_to_print_buffer += sl.len();
print_buffer.extend_from_slice(sl);
print_buffer.push(b'\n');
}
@ -379,7 +378,7 @@ mod fast_encode {
stdout_lock.write_all(print_buffer)?;
// Remove the bytes that were just printed from `encoded_buffer`
drop(encoded_buffer.drain(..number_of_bytes_to_drain));
drop(encoded_buffer.drain(..bytes_added_to_print_buffer));
if is_cleanup {
if encoded_buffer.is_empty() {