RGBCube/uutils-coreutils
1
Fork 0
mirror of https://github.com/RGBCube/uutils-coreutils synced 2025-07-28 03:27:44 +00:00
Code Issues Activity

Fix comments

Browse source
This commit is contained in:
electricboogie 2022-01-27 16:12:34 -06:00
parent 8b6c1337aa
commit 5e82d6069f
1 changed files with 2 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/uu/ls/src/ls.rs
View file

@ -1333,6 +1333,8 @@ impl PathData {
None => None, None => None,
}; };
// Why prefer to check the DirEntry file_type()? B/c the call is
// nearly free compared to a metadata() or file_type() call on a dir/file.
let ft = match de { let ft = match de {
Some(ref de) => { Some(ref de) => {
if let Ok(ft_de) = de.file_type() { if let Ok(ft_de) = de.file_type() {
@ -1572,11 +1574,6 @@ fn enter_directory(
}; };
if should_display(&dir_entry, config) { if should_display(&dir_entry, config) {
// Why prefer to check the DirEntry file_type()? B/c the call is
// nearly free compared to a metadata() or file_type() call on a dir/file.
//
// Why not print an error here? If we wait for the metadata() call, we make
// certain we print the error once. This also seems to match GNU behavior.
let entry_path_data = let entry_path_data =
PathData::new(dir_entry.path(), Some(Ok(dir_entry)), None, config, false); PathData::new(dir_entry.path(), Some(Ok(dir_entry)), None, config, false);
vec_path_data.push(entry_path_data); vec_path_data.push(entry_path_data);