RGBCube/uutils-coreutils
1
Fork 0
mirror of https://github.com/RGBCube/uutils-coreutils synced 2025-07-27 11:07:44 +00:00
Code Issues Activity

uucore/format: remove TODOs related to bigdecimal

Browse source
This commit is contained in:
Daniel Hofstetter 2025-04-01 17:15:59 +02:00
parent 636e4a777b
commit 60ebace7f2
1 changed files with 1 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/uucore/src/lib/features/format/num_format.rs
View file

@ -246,13 +246,7 @@ impl Formatter<&ExtendedBigDecimal> for Float {
*/ */
let (abs, negative) = match e { let (abs, negative) = match e {
ExtendedBigDecimal::BigDecimal(bd) => { ExtendedBigDecimal::BigDecimal(bd) => {
// Workaround printing bug in BigDecimal, force 0 to scale 0. (ExtendedBigDecimal::BigDecimal(bd.abs()), bd.is_negative())
// TODO: Remove after https://github.com/akubera/bigdecimal-rs/issues/144 is fixed.
if bd.is_zero() {
(ExtendedBigDecimal::zero(), false)
} else {
(ExtendedBigDecimal::BigDecimal(bd.abs()), bd.is_negative())
}
} }
ExtendedBigDecimal::MinusZero => (ExtendedBigDecimal::zero(), true), ExtendedBigDecimal::MinusZero => (ExtendedBigDecimal::zero(), true),
ExtendedBigDecimal::Infinity => (ExtendedBigDecimal::Infinity, false), ExtendedBigDecimal::Infinity => (ExtendedBigDecimal::Infinity, false),
@ -730,12 +724,8 @@ mod test {
} }
#[test] #[test]
#[ignore = "Need https://github.com/akubera/bigdecimal-rs/issues/144 to be fixed"]
fn decimal_float_zero() { fn decimal_float_zero() {
use super::format_float_decimal; use super::format_float_decimal;
// We've had issues with "0e10"/"0e-10" formatting.
// TODO: Enable after https://github.com/akubera/bigdecimal-rs/issues/144 is fixed,
// as our workaround is in .fmt.
let f = |digits, scale| { let f = |digits, scale| {
format_float_decimal(&BigDecimal::from_bigint(digits, scale), 6, ForceDecimal::No) format_float_decimal(&BigDecimal::from_bigint(digits, scale), 6, ForceDecimal::No)
}; };