Merge pull request #4820 from sylvestre/thru-dangling-2

cp: fix cp -f f loop when loop is a symlink loop

tests/by-util/test_cp.rs

@@ -2495,6 +2495,20 @@ fn test_remove_destination_symbolic_link_loop() {
     assert!(at.file_exists("loop"));
 }
 
+#[test]
+#[cfg(not(windows))]
+fn test_cp_symbolic_link_loop() {
+    let (at, mut ucmd) = at_and_ucmd!();
+    at.symlink_file("loop", "loop");
+    at.plus("loop");
+    at.touch("f");
+    ucmd.args(&["-f", "f", "loop"])
+        .succeeds()
+        .no_stdout()
+        .no_stderr();
+    assert!(at.file_exists("loop"));
+}
+
 /// Test that copying a directory to itself is disallowed.
 #[test]
 fn test_copy_directory_to_itself_disallowed() {

tests/by-util/test_mv.rs

@@ -72,7 +72,7 @@ fn test_mv_move_file_into_dir_with_target_arg() {
         .succeeds()
         .no_stderr();
 
-    assert!(at.file_exists(format!("{dir}/{file}")))
+    assert!(at.file_exists(format!("{dir}/{file}")));
 }
 
 #[test]
@@ -90,7 +90,7 @@ fn test_mv_move_file_into_file_with_target_arg() {
         .fails()
         .stderr_is(format!("mv: target directory '{file1}': Not a directory\n"));
 
-    assert!(at.file_exists(file1))
+    assert!(at.file_exists(file1));
 }
 
 #[test]