RGBCube/uutils-coreutils
1
Fork 0
mirror of https://github.com/RGBCube/uutils-coreutils synced 2025-09-15 03:26:18 +00:00
Code Issues Activity

Merge pull request #6042 from BenWiederhake/dev-chown-preserve-root

Browse source 
chown+chgrp+chmod: Fix handling of preserve root flag and error messages
This commit is contained in:
Sylvestre Ledru 2024-03-09 22:44:59 +01:00 • committed by GitHub
commit 6c29ed037b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 220 additions and 60 deletions
Download patch file Download diff file Expand all files Collapse all files

72
tests/by-util/test_chgrp.rs
View file

@ -85,18 +85,29 @@ fn test_fail_silently() {
#[test]
fn test_preserve_root() {
// It's weird that on OS X, `realpath /etc/..` returns '/private'
new_ucmd!()
.arg("--preserve-root")
.arg("-R")
.arg("bin")
.arg("/")
.fails()
.stderr_is("chgrp: it is dangerous to operate recursively on '/'\nchgrp: use --no-preserve-root to override this failsafe\n");
for d in [
"/",
"/////dev///../../../../",
"../../../../../../../../../../../../../../",
"./../../../../../../../../../../../../../../",
] {
let expected_error = format!(
"chgrp: it is dangerous to operate recursively on '{}' (same as '/')\nchgrp: use --no-preserve-root to override this failsafe\n",
d,
);
new_ucmd!()
.arg("--preserve-root")
.arg("-R")
.arg("bin").arg(d)
.arg("bin")
.arg(d)
.fails()
.stderr_is("chgrp: it is dangerous to operate recursively on '/'\nchgrp: use --no-preserve-root to override this failsafe\n");
.stderr_is(expected_error);
}
}
@ -105,17 +116,24 @@ fn test_preserve_root_symlink() {
let file = "test_chgrp_symlink2root";
for d in [
"/",
"//",
"///",
"////dev//../../../../",
"..//../../..//../..//../../../../../../../../",
".//../../../../../../..//../../../../../../../",
] {
let (at, mut ucmd) = at_and_ucmd!();
at.symlink_file(d, file);
let expected_error = format!(
"chgrp: it is dangerous to operate recursively on 'test_chgrp_symlink2root' (same as '/')\nchgrp: use --no-preserve-root to override this failsafe\n",
//d,
);
ucmd.arg("--preserve-root")
.arg("-HR")
.arg("bin").arg(file)
.arg("bin")
.arg(file)
.fails()
.stderr_is("chgrp: it is dangerous to operate recursively on '/'\nchgrp: use --no-preserve-root to override this failsafe\n");
.stderr_is(expected_error);
}
let (at, mut ucmd) = at_and_ucmd!();
@ -124,7 +142,7 @@ fn test_preserve_root_symlink() {
.arg("-HR")
.arg("bin").arg(format!(".//{file}/..//..//../../"))
.fails()
.stderr_is("chgrp: it is dangerous to operate recursively on '/'\nchgrp: use --no-preserve-root to override this failsafe\n");
.stderr_is("chgrp: it is dangerous to operate recursively on './/test_chgrp_symlink2root/..//..//../../' (same as '/')\nchgrp: use --no-preserve-root to override this failsafe\n");
let (at, mut ucmd) = at_and_ucmd!();
at.symlink_file("/", "__root__");
@ -132,7 +150,47 @@ fn test_preserve_root_symlink() {
.arg("-R")
.arg("bin").arg("__root__/.")
.fails()
.stderr_is("chgrp: it is dangerous to operate recursively on '/'\nchgrp: use --no-preserve-root to override this failsafe\n");
.stderr_is("chgrp: it is dangerous to operate recursively on '__root__/.' (same as '/')\nchgrp: use --no-preserve-root to override this failsafe\n");
}
#[test]
fn test_preserve_root_symlink_cwd_root() {
new_ucmd!()
.current_dir("/")
.arg("--preserve-root")
.arg("-R")
.arg("bin").arg(".")
.fails()
.stderr_is("chgrp: it is dangerous to operate recursively on '.' (same as '/')\nchgrp: use --no-preserve-root to override this failsafe\n");
new_ucmd!()
.current_dir("/")
.arg("--preserve-root")
.arg("-R")
.arg("bin").arg("/.")
.fails()
.stderr_is("chgrp: it is dangerous to operate recursively on '/.' (same as '/')\nchgrp: use --no-preserve-root to override this failsafe\n");
new_ucmd!()
.current_dir("/")
.arg("--preserve-root")
.arg("-R")
.arg("bin").arg("..")
.fails()
.stderr_is("chgrp: it is dangerous to operate recursively on '..' (same as '/')\nchgrp: use --no-preserve-root to override this failsafe\n");
new_ucmd!()
.current_dir("/")
.arg("--preserve-root")
.arg("-R")
.arg("bin").arg("/..")
.fails()
.stderr_is("chgrp: it is dangerous to operate recursively on '/..' (same as '/')\nchgrp: use --no-preserve-root to override this failsafe\n");
new_ucmd!()
.current_dir("/")
.arg("--preserve-root")
.arg("-R")
.arg("bin")
.arg("...")
.fails()
.stderr_is("chgrp: cannot access '...': No such file or directory\n");
}
#[test]