From 71248a1ecb8847b1c6f802023fc87473812e5d10 Mon Sep 17 00:00:00 2001
From: Sylvestre Ledru <sylvestre@debian.org>
Date: Mon, 10 Feb 2025 13:07:21 +0100
Subject: [PATCH] CI: use notice for intermittent issues instead of warnings

---
 .github/workflows/GnuTests.yml | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/GnuTests.yml b/.github/workflows/GnuTests.yml
index e4a2558fb..e4b524047 100644
--- a/.github/workflows/GnuTests.yml
+++ b/.github/workflows/GnuTests.yml
@@ -273,7 +273,7 @@ jobs:
                   have_new_failures="true"
                 else
                   MSG="Skip an intermittent issue ${LINE} (fails in this run but passes in the 'main' branch)"
-                  echo "::warning ::$MSG"
+                  echo "::notice ::$MSG"
                   echo $MSG >> ${COMMENT_LOG}
                   echo ""
                 fi
@@ -291,7 +291,7 @@ jobs:
                   echo $MSG >> ${COMMENT_LOG}
                 else
                   MSG="Skipping an intermittent issue ${LINE} (passes in this run but fails in the 'main' branch)"
-                  echo "::warning ::$MSG"
+                  echo "::notice ::$MSG"
                   echo $MSG >> ${COMMENT_LOG}
                   echo ""
                 fi
@@ -340,7 +340,10 @@ jobs:
         # Compare root tests
         compare_tests '${{ steps.vars.outputs.path_GNU_tests }}/test-suite-root.log' "${ROOT_REF_LOG_FILE}" "root"
 
-        if test -n "${have_new_failures}" ; then exit -1 ; fi
+        if [ -n "${have_new_failures}" ]; then
+          echo "::error ::Found new test failures"
+          exit 1
+        fi
     - name: Upload comparison log (for GnuComment workflow)
       if: success() || failure() # run regardless of prior step success/failure
       uses: actions/upload-artifact@v4