From d41591f2936d4396e91dcb165ebe23315c6bd046 Mon Sep 17 00:00:00 2001 From: Sylvestre Ledru Date: Sat, 18 Mar 2023 17:41:27 +0100 Subject: [PATCH 1/2] CI: move the intermittent list into a file --- .github/workflows/GnuTests.yml | 2 +- .github/workflows/ignore-intermittent.txt | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) create mode 100644 .github/workflows/ignore-intermittent.txt diff --git a/.github/workflows/GnuTests.yml b/.github/workflows/GnuTests.yml index 7c8c307ec..a34780173 100644 --- a/.github/workflows/GnuTests.yml +++ b/.github/workflows/GnuTests.yml @@ -203,7 +203,7 @@ jobs: REPO_DEFAULT_BRANCH='${{ steps.vars.outputs.repo_default_branch }}' # https://github.com/uutils/coreutils/issues/4294 # https://github.com/uutils/coreutils/issues/4295 - IGNORE_INTERMITTENT='tests/tail-2/inotify-dir-recreate tests/misc/timeout tests/rm/rm1' + IGNORE_INTERMITTENT='.github/workflows/ignore-intermittent.txt' mkdir -p ${{ steps.vars.outputs.path_reference }} diff --git a/.github/workflows/ignore-intermittent.txt b/.github/workflows/ignore-intermittent.txt new file mode 100644 index 000000000..759bd96eb --- /dev/null +++ b/.github/workflows/ignore-intermittent.txt @@ -0,0 +1,3 @@ +tests/tail-2/inotify-dir-recreate +tests/misc/timeout +tests/rm/rm1 From 7fd0e1e64dcf9bf507bc06d209f29b17a717228f Mon Sep 17 00:00:00 2001 From: Sylvestre Ledru Date: Sat, 18 Mar 2023 17:42:08 +0100 Subject: [PATCH 2/2] CI: Also ignore intermittent when starting to pass Example: Congrats! The gnu test tests/tail-2/inotify-dir-recreate is no longer failing! --- .github/workflows/GnuTests.yml | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/.github/workflows/GnuTests.yml b/.github/workflows/GnuTests.yml index a34780173..eb38f75a0 100644 --- a/.github/workflows/GnuTests.yml +++ b/.github/workflows/GnuTests.yml @@ -226,9 +226,17 @@ jobs: for LINE in ${REF_FAILING} do if ! grep -Fxq ${LINE}<<<"${NEW_FAILING}"; then - MSG="Congrats! The gnu test ${LINE} is no longer failing!" - echo "::warning ::$MSG" - echo $MSG >> ${COMMENT_LOG} + if ! grep ${LINE} ${IGNORE_INTERMITTENT} + then + MSG="Congrats! The gnu test ${LINE} is no longer failing!" + echo "::warning ::$MSG" + echo $MSG >> ${COMMENT_LOG} + else + MSG="Skipping an intermittent issue ${LINE}" + echo "::warning ::$MSG" + echo $MSG >> ${COMMENT_LOG} + echo "" + fi fi done for LINE in ${NEW_FAILING}