From 750b68a44c759c2530c4131c203b9be005e3a381 Mon Sep 17 00:00:00 2001
From: Roy Ivy III <rivy.dev@gmail.com>
Date: Sat, 5 Jun 2021 23:28:19 -0500
Subject: [PATCH] refactor/printf ~ fix `cargo clippy` complaint
 (clippy::needless_borrow)

---
 .../tokenize/num_format/formatters/cninetyninehexfloatf.rs    | 2 +-
 .../printf/src/tokenize/num_format/formatters/float_common.rs | 4 ++--
 src/uu/printf/src/tokenize/num_format/formatters/floatf.rs    | 2 +-
 src/uu/printf/src/tokenize/num_format/formatters/intf.rs      | 4 ++--
 src/uu/printf/src/tokenize/num_format/num_format.rs           | 2 +-
 src/uu/printf/src/tokenize/sub.rs                             | 2 +-
 6 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/uu/printf/src/tokenize/num_format/formatters/cninetyninehexfloatf.rs b/src/uu/printf/src/tokenize/num_format/formatters/cninetyninehexfloatf.rs
index f96a991b5..0ca993680 100644
--- a/src/uu/printf/src/tokenize/num_format/formatters/cninetyninehexfloatf.rs
+++ b/src/uu/printf/src/tokenize/num_format/formatters/cninetyninehexfloatf.rs
@@ -26,7 +26,7 @@ impl Formatter for CninetyNineHexFloatf {
     ) -> Option<FormatPrimitive> {
         let second_field = field.second_field.unwrap_or(6) + 1;
         let analysis = FloatAnalysis::analyze(
-            &str_in,
+            str_in,
             initial_prefix,
             Some(second_field as usize),
             None,
diff --git a/src/uu/printf/src/tokenize/num_format/formatters/float_common.rs b/src/uu/printf/src/tokenize/num_format/formatters/float_common.rs
index dd8259233..dfd64296c 100644
--- a/src/uu/printf/src/tokenize/num_format/formatters/float_common.rs
+++ b/src/uu/printf/src/tokenize/num_format/formatters/float_common.rs
@@ -298,11 +298,11 @@ pub fn get_primitive_dec(
 pub fn primitive_to_str_common(prim: &FormatPrimitive, field: &FormatField) -> String {
     let mut final_str = String::new();
     if let Some(ref prefix) = prim.prefix {
-        final_str.push_str(&prefix);
+        final_str.push_str(prefix);
     }
     match prim.pre_decimal {
         Some(ref pre_decimal) => {
-            final_str.push_str(&pre_decimal);
+            final_str.push_str(pre_decimal);
         }
         None => {
             panic!(
diff --git a/src/uu/printf/src/tokenize/num_format/formatters/floatf.rs b/src/uu/printf/src/tokenize/num_format/formatters/floatf.rs
index aed50f18e..afb2bcf08 100644
--- a/src/uu/printf/src/tokenize/num_format/formatters/floatf.rs
+++ b/src/uu/printf/src/tokenize/num_format/formatters/floatf.rs
@@ -21,7 +21,7 @@ impl Formatter for Floatf {
     ) -> Option<FormatPrimitive> {
         let second_field = field.second_field.unwrap_or(6) + 1;
         let analysis = FloatAnalysis::analyze(
-            &str_in,
+            str_in,
             initial_prefix,
             None,
             Some(second_field as usize),
diff --git a/src/uu/printf/src/tokenize/num_format/formatters/intf.rs b/src/uu/printf/src/tokenize/num_format/formatters/intf.rs
index 02c59211b..b6c18d436 100644
--- a/src/uu/printf/src/tokenize/num_format/formatters/intf.rs
+++ b/src/uu/printf/src/tokenize/num_format/formatters/intf.rs
@@ -252,7 +252,7 @@ impl Formatter for Intf {
     fn primitive_to_str(&self, prim: &FormatPrimitive, field: FormatField) -> String {
         let mut final_str: String = String::new();
         if let Some(ref prefix) = prim.prefix {
-            final_str.push_str(&prefix);
+            final_str.push_str(prefix);
         }
         // integral second fields is zero-padded minimum-width
         // which gets handled before general minimum-width
@@ -266,7 +266,7 @@ impl Formatter for Intf {
                         i -= 1;
                     }
                 }
-                final_str.push_str(&pre_decimal);
+                final_str.push_str(pre_decimal);
             }
             None => {
                 panic!(
diff --git a/src/uu/printf/src/tokenize/num_format/num_format.rs b/src/uu/printf/src/tokenize/num_format/num_format.rs
index c030358bb..b32731f2d 100644
--- a/src/uu/printf/src/tokenize/num_format/num_format.rs
+++ b/src/uu/printf/src/tokenize/num_format/num_format.rs
@@ -235,7 +235,7 @@ pub fn num_format(field: &FormatField, in_str_opt: Option<&String>) -> Option<St
                     let as_str = format!("{}", provided_num);
                     let initial_prefix = get_initial_prefix(
                         &as_str,
-                        &field.field_type
+                        field.field_type
                     );
                     tmp=formatter.get_primitive(field, &initial_prefix, &as_str)
                         .expect("err during default provided num");
diff --git a/src/uu/printf/src/tokenize/sub.rs b/src/uu/printf/src/tokenize/sub.rs
index 249003f85..d01e00699 100644
--- a/src/uu/printf/src/tokenize/sub.rs
+++ b/src/uu/printf/src/tokenize/sub.rs
@@ -275,7 +275,7 @@ impl SubParser {
                 }
                 None => {
                     text_so_far.push('%');
-                    err_conv(&text_so_far);
+                    err_conv(text_so_far);
                     false
                 }
             }