RGBCube/uutils-coreutils
1
Fork 0
mirror of https://github.com/RGBCube/uutils-coreutils synced 2025-07-29 12:07:46 +00:00
Code Issues Activity

factor: Slightly refactor main loop, fix bug

Browse source
This commit is contained in:
nicoo 2020-08-09 17:23:57 +02:00 • committed by Roy Ivy III
parent b7b0c76b8e
commit 78ae0cca31
1 changed files with 19 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

32
src/uu/factor/src/factor.rs
View file

@ -173,24 +173,30 @@ pub fn factor(num: u64) -> Factors {
let mut tmp = Decomposition::one(); let mut tmp = Decomposition::one();
non_trivial_gcd = false; non_trivial_gcd = false;
for i in 0..gcd_queue.0.len() - 1 { for i in 0..gcd_queue.0.len() - 1 {
let (a, e_a) = gcd_queue.0[i]; let (mut a, e_a) = gcd_queue.0[i];
let (b, e_b) = gcd_queue.0[i + 1]; let (mut b, e_b) = gcd_queue.0[i + 1];
if a == 1 {
continue;
}
let g = gcd(a, b); let g = gcd(a, b);
if g != 1 { if g != 1 {
non_trivial_gcd = true; non_trivial_gcd = true;
tmp.add(a / g, e_a); a /= g;
tmp.add(g, e_a + e_b); b /= g;
if i + 1 == gcd_queue.0.len() { }
tmp.add(b / g, e_b) if a != 1 {
} else {
gcd_queue.0[i + 1] = (b / g, e_b);
}
} else {
tmp.add(a, e_a); tmp.add(a, e_a);
if i + 1 == gcd_queue.0.len() - 1 { }
tmp.add(b, e_b) if g != 1 {
} tmp.add(g, e_a + e_b);
}
if i + 1 != gcd_queue.0.len() - 1 {
gcd_queue.0[i + 1].0 = b;
} else if b != 1 {
tmp.add(b, e_b);
} }
} }
gcd_queue = tmp; gcd_queue = tmp;