Merge pull request #2400 from youknowone/line-ends

cleaning up str ends checks

src/uu/basename/src/basename.rs

@@ -118,14 +118,7 @@ pub fn uumain(args: impl uucore::Args) -> i32 {
 
 fn basename(fullname: &str, suffix: &str) -> String {
     // Remove all platform-specific path separators from the end
-    let mut path: String = fullname
+    let path = fullname.trim_end_matches(is_separator);
-        .chars()
-        .rev()
-        .skip_while(|&ch| is_separator(ch))
-        .collect();
-
-    // Undo reverse
-    path = path.chars().rev().collect();
 
     // Convert to path buffer and get last path component
     let pb = PathBuf::from(path);

src/uu/comm/src/comm.rs

@@ -50,9 +50,8 @@ fn mkdelim(col: usize, opts: &ArgMatches) -> String {
 }
 
 fn ensure_nl(line: &mut String) {
-    match line.chars().last() {
+    if !line.ends_with('\n') {
-        Some('\n') => (),
+        line.push('\n');
-        _ => line.push('\n'),
     }
 }