Merge pull request #2811 from jfinkels/od-uresult

od: return UResult from uumain() function

src/uu/od/src/od.rs

@@ -44,6 +44,7 @@ use crate::peekreader::*;
 use crate::prn_char::format_ascii_dump;
 use clap::{self, crate_version, AppSettings, Arg, ArgMatches};
 use uucore::display::Quotable;
+use uucore::error::{UResult, USimpleError};
 use uucore::parse_size::ParseSizeError;
 use uucore::InvalidEncodingHandling;
 
@@ -120,25 +121,36 @@ struct OdOptions {
 }
 
 impl OdOptions {
-    fn new(matches: ArgMatches, args: Vec<String>) -> Result<OdOptions, String> {
+    fn new(matches: ArgMatches, args: Vec<String>) -> UResult<OdOptions> {
         let byte_order = match matches.value_of(options::ENDIAN) {
             None => ByteOrder::Native,
             Some("little") => ByteOrder::Little,
             Some("big") => ByteOrder::Big,
             Some(s) => {
-                return Err(format!("Invalid argument --endian={}", s));
+                return Err(USimpleError::new(
+                    1,
+                    format!("Invalid argument --endian={}", s),
+                ));
             }
         };
 
-        let mut skip_bytes = matches.value_of(options::SKIP_BYTES).map_or(0, |s| {
+        let mut skip_bytes = match matches.value_of(options::SKIP_BYTES) {
-            parse_number_of_bytes(s).unwrap_or_else(|e| {
+            None => 0,
-                crash!(1, "{}", format_error_message(e, s, options::SKIP_BYTES))
+            Some(s) => match parse_number_of_bytes(s) {
-            })
+                Ok(n) => n,
-        });
+                Err(e) => {
+                    return Err(USimpleError::new(
+                        1,
+                        format_error_message(e, s, options::SKIP_BYTES),
+                    ))
+                }
+            },
+        };
 
         let mut label: Option<usize> = None;
 
-        let parsed_input = parse_inputs(&matches).map_err(|e| format!("Invalid inputs: {}", e))?;
+        let parsed_input = parse_inputs(&matches)
+            .map_err(|e| USimpleError::new(1, format!("Invalid inputs: {}", e)))?;
         let input_strings = match parsed_input {
             CommandLineInputs::FileNames(v) => v,
             CommandLineInputs::FileAndOffset((f, s, l)) => {
@@ -148,15 +160,26 @@ impl OdOptions {
             }
         };
 
-        let formats = parse_format_flags(&args)?;
+        let formats = parse_format_flags(&args).map_err(|e| USimpleError::new(1, e))?;
 
-        let mut line_bytes = matches.value_of(options::WIDTH).map_or(16, |s| {
+        let mut line_bytes = match matches.value_of(options::WIDTH) {
+            None => 16,
+            Some(s) => {
                 if matches.occurrences_of(options::WIDTH) == 0 {
-                return 16;
+                    16
+                } else {
+                    match parse_number_of_bytes(s) {
+                        Ok(n) => n,
+                        Err(e) => {
+                            return Err(USimpleError::new(
+                                1,
+                                format_error_message(e, s, options::WIDTH),
+                            ))
+                        }
+                    }
+                }
+            }
         };
-            parse_number_of_bytes(s)
-                .unwrap_or_else(|e| crash!(1, "{}", format_error_message(e, s, options::WIDTH)))
-        });
 
         let min_bytes = formats.iter().fold(1, |max, next| {
             cmp::max(max, next.formatter_item_info.byte_size)
@@ -168,18 +191,28 @@ impl OdOptions {
 
         let output_duplicates = matches.is_present(options::OUTPUT_DUPLICATES);
 
-        let read_bytes = matches.value_of(options::READ_BYTES).map(|s| {
+        let read_bytes = match matches.value_of(options::READ_BYTES) {
-            parse_number_of_bytes(s).unwrap_or_else(|e| {
+            None => None,
-                crash!(1, "{}", format_error_message(e, s, options::READ_BYTES))
+            Some(s) => match parse_number_of_bytes(s) {
-            })
+                Ok(n) => Some(n),
-        });
+                Err(e) => {
+                    return Err(USimpleError::new(
+                        1,
+                        format_error_message(e, s, options::READ_BYTES),
+                    ))
+                }
+            },
+        };
 
         let radix = match matches.value_of(options::ADDRESS_RADIX) {
             None => Radix::Octal,
             Some(s) => {
                 let st = s.as_bytes();
                 if st.len() != 1 {
-                    return Err("Radix must be one of [d, o, n, x]".to_string());
+                    return Err(USimpleError::new(
+                        1,
+                        "Radix must be one of [d, o, n, x]".to_string(),
+                    ));
                 } else {
                     let radix: char =
                         *(st.get(0).expect("byte string of length 1 lacks a 0th elem")) as char;
@@ -188,7 +221,12 @@ impl OdOptions {
                         'x' => Radix::Hexadecimal,
                         'o' => Radix::Octal,
                         'n' => Radix::NoPrefix,
-                        _ => return Err("Radix must be one of [d, o, n, x]".to_string()),
+                        _ => {
+                            return Err(USimpleError::new(
+                                1,
+                                "Radix must be one of [d, o, n, x]".to_string(),
+                            ))
+                        }
                     }
                 }
             }
@@ -210,7 +248,8 @@ impl OdOptions {
 
 /// parses and validates command line parameters, prepares data structures,
 /// opens the input and calls `odfunc` to process the input.
-pub fn uumain(args: impl uucore::Args) -> i32 {
+#[uucore_procs::gen_uumain]
+pub fn uumain(args: impl uucore::Args) -> UResult<()> {
     let args = args
         .collect_str(InvalidEncodingHandling::Ignore)
         .accept_any();
@@ -221,12 +260,7 @@ pub fn uumain(args: impl uucore::Args) -> i32 {
         .clone() // Clone to reuse clap_opts to print help
         .get_matches_from(args.clone());
 
-    let od_options = match OdOptions::new(clap_matches, args) {
+    let od_options = OdOptions::new(clap_matches, args)?;
-        Err(s) => {
-            crash!(1, "{}", s);
-        }
-        Ok(o) => o,
-    };
 
     let mut input_offset =
         InputOffset::new(od_options.radix, od_options.skip_bytes, od_options.label);
@@ -482,7 +516,7 @@ fn odfunc<I>(
     input_offset: &mut InputOffset,
     input_decoder: &mut InputDecoder<I>,
     output_info: &OutputInfo,
-) -> i32
+) -> UResult<()>
 where
     I: PeekRead + HasError,
 {
@@ -540,15 +574,15 @@ where
             Err(e) => {
                 show_error!("{}", e);
                 input_offset.print_final_offset();
-                return 1;
+                return Err(1.into());
             }
         };
     }
 
     if input_decoder.has_error() {
-        1
+        Err(1.into())
     } else {
-        0
+        Ok(())
     }
 }