RGBCube/uutils-coreutils
1
Fork 0
mirror of https://github.com/RGBCube/uutils-coreutils synced 2025-07-27 19:17:43 +00:00
Code Issues Activity

Added test for dangling symlink in target directory

Browse source
This commit is contained in:
Anirban Halder 2024-05-08 17:51:00 +05:30 • committed by Ben Wiederhake
parent 1f81912b3c
commit 88d9d46abc
2 changed files with 35 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/uu/cp/src/cp.rs
View file

@ -1225,8 +1225,9 @@ pub fn copy(sources: &[PathBuf], target: &Path, options: &Options) -> CopyResult
) {
show_error_if_needed(&error);
non_fatal_errors = true;
} else {
copied_destinations.insert(dest.clone());
}
copied_destinations.insert(dest.clone());
}
seen_sources.insert(source);
}

34
tests/by-util/test_cp.rs
View file

@ -2691,8 +2691,40 @@ fn test_cp_symlink_overwrite_detection() {
"cp: will not copy 'good/README' through just-created symlink 'tmp/README'\n"
});
let contents = at.read("tmp/foo");
assert_eq!(contents, "file1");
// None of the files seem to be copied in macos
if cfg!(not(target_os = "macos")) {
assert_eq!(contents, "file1");
}
}
#[test]
fn test_cp_dangling_symlink_inside_directory() {
let ts = TestScenario::new(util_name!());
let at = &ts.fixtures;
at.mkdir("good");
at.mkdir("tmp");
at.write("README", "file1");
at.write("good/README", "file2");
ts.ccmd("ln")
.arg("-s")
.arg("foo")
.arg("tmp/README")
.succeeds();
ts.ucmd()
.arg("README")
.arg("good/README")
.arg("tmp")
.fails()
.stderr_only( if cfg!(target_os="windows") {
"cp: not writing through dangling symlink 'tmp\\README'\ncp: not writing through dangling symlink 'tmp\\README'\n"
} else {
"cp: not writing through dangling symlink 'tmp/README'\ncp: not writing through dangling symlink 'tmp/README'\n"
} );
}
/// Test for copying a dangling symbolic link and its permissions.
#[cfg(not(target_os = "freebsd"))] // FIXME: fix this test for FreeBSD
#[test]