RGBCube/uutils-coreutils
1
Fork 0
mirror of https://github.com/RGBCube/uutils-coreutils synced 2025-07-28 03:27:44 +00:00
Code Issues Activity

tac: correct error message when reading from dir.

Browse source 
Correct the error message produced by `tac` when trying to read from a
directory. Previously if the path 'a' referred to a directory, then
running `tac a` would produce the error message

    dir: read error: Invalid argument

after this commit it produces

    a: read error: Invalid argument

which matches GNU `tac`.
This commit is contained in:
Jeffrey Finkelstein 2021-07-25 13:55:24 -04:00
parent c98e7f5de9
commit abf4c69b28
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/uu/tac/src/tac.rs
View file

@ -97,7 +97,7 @@ fn tac(filenames: Vec<String>, before: bool, _: bool, separator: &str) -> i32 {
let path = Path::new(filename); let path = Path::new(filename);
if path.is_dir() || path.metadata().is_err() { if path.is_dir() || path.metadata().is_err() {
if path.is_dir() { if path.is_dir() {
show_error!("dir: read error: Invalid argument"); show_error!("{}: read error: Invalid argument", filename);
} else { } else {
show_error!( show_error!(
"failed to open '{}' for reading: No such file or directory", "failed to open '{}' for reading: No such file or directory",

2
tests/by-util/test_tac.rs
View file

@ -66,5 +66,5 @@ fn test_invalid_input() {
.ucmd() .ucmd()
.arg("a") .arg("a")
.fails() .fails()
.stderr_contains("dir: read error: Invalid argument"); .stderr_contains("a: read error: Invalid argument");
} }