RGBCube/uutils-coreutils
1
Fork 0
mirror of https://github.com/RGBCube/uutils-coreutils synced 2025-07-28 19:47:45 +00:00
Code Issues Activity

Merge pull request #1128 from bltnkl/tail_readme_fix

Browse source 
tail: add spaces after hashes
This commit is contained in:
Alex Lyon 2018-01-06 10:37:53 -08:00 • committed by GitHub
commit ac797b95ee
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/tail/README.md
View file

@ -1,14 +1,13 @@
Rudimentary tail implementation.
##Missing features:
## Missing features:
### Flags with features
* `--max-unchanged-stats` : with `--follow=name`, reopen a FILE which has not changed size after N (default 5) iterations to see if it has been unlinked or renamed (this is the usual case of rotated log files). With inotify, this option is rarely useful.
* `--quiet` : never output headers giving file names
* `--retry` : keep trying to open a file even when it is or becomes inaccessible; useful when follow‐ing by name, i.e., with `--follow=name`
### Others
The current implementation does not handle `-` as an alias for stdin.
##Possible optimizations:
## Possible optimizations:
* Don't read the whole file if not using `-f` and input is regular file. Read in chunks from the end going backwards, reading each individual chunk forward.

6
src/tail/tail.rs
View file

@ -79,8 +79,8 @@ pub fn uumain(args: Vec<String>) -> i32 {
opts.optflag("h", "help", "help");
opts.optflag("V", "version", "version");
opts.optflag("v", "verbose", "always output headers giving file names");
// TODO: --silent flag as alias to --quiet
opts.optflag("q", "quiet", "never output headers giving file names");
opts.optflag("", "silent", "synonym of --quiet");
let given_options = match opts.parse(&args) {
Ok (m) => { m }
@ -167,7 +167,7 @@ pub fn uumain(args: Vec<String>) -> i32 {
}
let verbose = given_options.opt_present("v");
let quiet = given_options.opt_present("q");
let quiet = given_options.opt_present("q") || given_options.opt_present("silent");
let files = given_options.free;
@ -181,7 +181,7 @@ pub fn uumain(args: Vec<String>) -> i32 {
for filename in &files {
if (multiple || verbose) && !quiet {
if !first_header { println!(""); }
if !first_header { println!(); }
println!("==> {} <==", filename);
}
first_header = false;